From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4YP/I1zX9GlrTQkAWB0awg (envelope-from ) for ; Fri, 01 May 2026 12:39:56 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=lYwsuI27; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 905451E067; Fri, 01 May 2026 12:39:56 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E1C6B1E067 for ; Fri, 01 May 2026 12:39:55 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id C400F46A9CC7 for ; Fri, 1 May 2026 16:39:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C400F46A9CC7 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=lYwsuI27 Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) by sourceware.org (Postfix) with ESMTPS id 0F00C4AA396C for ; Fri, 1 May 2026 16:39:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0F00C4AA396C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0F00C4AA396C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777653571; cv=none; b=E12fSV9fwEWIHhAvTQXMUhJ8MRGO8R3Z5It60A1MzsSrCS89l43kQ66dfGb2gixzefJ1Q1EL2aQC2GmQb7zHxH41yzF3sGrk5qS1XAIFrWGjdneICfiUQy3YHC4qouC8yv1a/6zp0482oQ+wLjHZelk67YRw5OLwSZcM2Y3qdJ0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777653571; c=relaxed/simple; bh=mwnAeibE1bwAYKHWxQC6IWEEkbbmCRaR1AkLL8HS6bU=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=iSQXt5Dv65PcR/20Pn9MvQLKqXBkjhJxJdjgMUzwIaZpjFa+7L/4U+1Td92RkqM10Ni1wcjDNdaU9R9DvRLWQHgaGJcP611FCJJ/82SE+Xvn/8/gd6MuLiePeyw7zP4s6Rx54KgWP9tb/k1+Tyglt/G7AWyfG3Czk3QV+gq98zU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0F00C4AA396C Received: from eig-obgw-5005b.ext.cloudfilter.net ([10.0.29.189]) by cmsmtp with ESMTPS id IX0kwcyb2nv6VIqtmwF2IM; Fri, 01 May 2026 16:39:30 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id IqtmwvYs2TFL7IqtmwITDk; Fri, 01 May 2026 16:39:30 +0000 X-Authority-Analysis: v=2.4 cv=euTfzppX c=1 sm=1 tr=0 ts=69f4d742 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=NGcC8JguVDcA:10 a=ItBw4LHWJt0A:10 a=20KFwNOVAAAA:8 a=RV9i5XtFJh0bU9N_1LAA:9 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=aZRa/8s/ivE8gXlTDpC3JjYijM0kcuScduehdUw7IjM=; b=lYwsuI27i3jdtnubQOicMsSkG+ Gy1+6pzSittYF3rLggm6zoODxVWDTdkhO/ZJbfeytz+jnnT95Hgg/iuy1mRxP/p/8VAvMfNZS7LMq 3V+Hew+lvzLccxZ27y+ugpuzt; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:53900 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wIqtm-00000001Kct-0hLJ; Fri, 01 May 2026 10:39:29 -0600 From: Tom Tromey To: Keith Seitz Cc: Markus Metzger , gdb-patches@sourceware.org Subject: Re: [PATCH] gdb, btrace: support libipt v2.2 events In-Reply-To: <790c23b4-af98-4877-872d-2c92e134f6ca@redhat.com> (Keith Seitz's message of "Thu, 30 Apr 2026 11:11:36 -0700") References: <20260430112428.1537534-1-markus.t.metzger@intel.com> <790c23b4-af98-4877-872d-2c92e134f6ca@redhat.com> X-Attribution: Tom Date: Fri, 01 May 2026 10:39:28 -0600 Message-ID: <87pl3fgk3j.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1wIqtm-00000001Kct-0hLJ X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:53900 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfBx6MwA5alSWmGn4sTwFRdvhPOa3g0Epq5MmNaW8HkwRZGPlnhdp7+B7a2CCADXT93egRC17ZwxaAnL0B6o9bzmGY2lnHDy20ZsU1TDS7x2BE9XqIWoE ovn3+8TSY0RSoFBSAZvT3M214cDohvZlT5gC+ijkzhVrA5FghGf3vpDzLz6rXKvG5ergDpQg7OJNFlFL0SWNV+iLAbFYIlYxBzE= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Keith" == Keith Seitz writes: >> + std::string aux_string = std::string (_("trig: trbv = ")) >> + + hex_string (event.variant.trig.trbv); Normally here we'd wrap the RSH in parens, per the coding standards. >> +#endif /* (LIBIPT_VERSION >= 0x202) */ Keith> Elsewhere in the file, this comment includes "defined". True but those spots seem to be in error. Tom