From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id sWgJC6Tw+Wlk1BYAWB0awg (envelope-from ) for ; Tue, 05 May 2026 09:29:08 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=KG0DNI7G; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 281C01E0BA; Tue, 05 May 2026 09:29:08 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 476BF1E067 for ; Tue, 05 May 2026 09:29:07 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 27B3A4BA79AF for ; Tue, 5 May 2026 13:29:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 27B3A4BA79AF Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=KG0DNI7G Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id CF90E4BA2E24 for ; Tue, 5 May 2026 13:28:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CF90E4BA2E24 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CF90E4BA2E24 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777987710; cv=none; b=navERUbhbtj2fsMhfXs1YxIg9cG/AG9N4wcQCTcXZ9Xxze1XQoFs7BYRtmc1zleckNjG5emkmSRKqIOx5RyL+FQGV6S7b2mE9YcRDGolxeySu09DLBan84OzSw+0HoK1FMl2G/HOdFp97N0hOZWJdvvQRnXck6O5Gicz+9v7Kqk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777987710; c=relaxed/simple; bh=xynZWl2KKq5BNoxPGDWa1/Rw4MYvinfipQrqXV8JdRk=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=KJIjF7dbMYywujtY0cfke+wsWdSxvGx+LdTYEq1RcDXzf2McopUO+liUuTKt3FM1B2CKTD4wnoerSGkDFBj9Y8HHKrcHcanFfHJIEydmf0nLtN1of2gL+ZH8OjN0fAyghG+Q6o7nwo9T26/+SxCrwTkIh4RF+a+AqOWBqRsv1HU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CF90E4BA2E24 Received: from eig-obgw-6003b.ext.cloudfilter.net ([10.0.30.175]) by cmsmtp with ESMTPS id KEiYwOBjEjw8YKFp6wy5mq; Tue, 05 May 2026 13:28:28 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id KFp3wIiVxWrBXKFp3wBvUr; Tue, 05 May 2026 13:28:25 +0000 X-Authority-Analysis: v=2.4 cv=ALkt6GG8 c=1 sm=1 tr=0 ts=69f9f07a a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=NGcC8JguVDcA:10 a=ItBw4LHWJt0A:10 a=3RSyDJDs_flKlSB9WwYA:9 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=FKWXpIsFqLzlyXqpTA+hBANyN3/WUuxzhzw6Rmn7bR4=; b=KG0DNI7Gc6EKkddxCs0sT9hxgn qp03YSzRxr0KbKmIn2gYtC4EYOIhRQDY1lvXzK+zgNrFxh2psQ8UyRBnlA8vLQnaMro3KJ5HGydwx A5qpXVGdr9LGKVDXo++csYxDf; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:48434 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.99.2) (envelope-from ) id 1wKFp3-000000018Ur-0h0c; Tue, 05 May 2026 07:28:25 -0600 From: Tom Tromey To: "Metzger, Markus T" Cc: Tom Tromey , "gdb-patches@sourceware.org" , Keith Seitz Subject: Re: [PATCH] gdb, btrace: support libipt v2.2 events In-Reply-To: (Markus T. Metzger's message of "Mon, 4 May 2026 07:16:13 +0000") References: <20260430112428.1537534-1-markus.t.metzger@intel.com> <790c23b4-af98-4877-872d-2c92e134f6ca@redhat.com> <87pl3fgk3j.fsf@tromey.com> X-Attribution: Tom Date: Tue, 05 May 2026 07:28:24 -0600 Message-ID: <87se86f0jr.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1wKFp3-000000018Ur-0h0c X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:48434 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfFKKgnmfUZs9vRfTtJlvY8NqnEitJcQ7UELrdrrtlMVHLQ96b/KDnKAovEBzIuLHiUM+Bq4k8YdK+GkP3XAmwM+o2wTGe80/E9bQUSkFH5Re2SZ2WKAE 7ca3zAGdRlmHErvP79LUShzPvnZ8OFAO1quqG9gQ4RPnKJP3ZqBvnK7PMUkkqzGBekHJebjhO47ZKstBow95b+CLjqxPD5mBpvY= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org > I'd need to break at the =, then, like this: > std::string aux_string > = (std::string (_("trig: trbv = ")) > + hex_string (event.variant.trig.trbv)); > The patch matches the surrounding style, so if you want this fixed, I'd need > to fix it everywhere in a separate patch. In gdb it's pretty normal for some code to be weird or wrong. For example tdep files are less reviewed than others. However the presence of some code that isn't standards-conformant doesn't mean that new code should be. You see this a lot with things like NULL/nullptr -- using nullptr in new code doesn't imply that all the old code has to be updated at the same time. So IMO new code should follow the relevant coding standards, even if other code in the same function does not. thanks, Tom