From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id MQp5A32b82lZtAYAWB0awg (envelope-from ) for ; Thu, 30 Apr 2026 14:12:13 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=FiyABWqv; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id EB7D91E067; Thu, 30 Apr 2026 14:12:12 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5E46B1E067 for ; Thu, 30 Apr 2026 14:12:12 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id E29D5436A040 for ; Thu, 30 Apr 2026 18:12:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E29D5436A040 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=FiyABWqv Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id A0D4F436F3C4 for ; Thu, 30 Apr 2026 18:11:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A0D4F436F3C4 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A0D4F436F3C4 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777572707; cv=none; b=lcswQLGmJHSYV8kppCpUDw8aEkZZlwNQlUD0hVo12QDZWETaj1B4cdWuBVOEkM09qGUwO6mxGyOhNfFLsOcW5Ev0tSHNRYyEq1sKG7HlDf+Q2OeMPwAbz3Z2fTX6WffdDiUIb28S/Rz891VMp8jt11FZgEnMuraSm20tzJflB10= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777572707; c=relaxed/simple; bh=J5yOr0/ssoPB6tHiEHCPo48azsgcs/BxOppE4g1HLjQ=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=vMNHpXsROzFYctRz0o/5i0H7c1d7a6sVcPXky2/qPdNHFGqG9/jidnqMAN8lU0oHRZrovM8Xq/R9znJo9icCQHe/JAnxywhCnFDV2S89auVoxOoQs5qZZ+dzW0IPN9AMUKzxcLF0LUu9KhToQjqGf3bkIPXRGuUQI/6BxPSoZP4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A0D4F436F3C4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777572707; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lEHoETRm6gyxs0GbPIj+uCM9o6uEsTYwIm5rgODOr/s=; b=FiyABWqvmLdz+OmiTt2w1m/2yMj7CV1bCVt5hqaGhvyHXgiijBPllvA8ztpZ1lYHzfzEqs T1vAgJ9E86rtWZkTqys04Sne+hFTV0+/7cP5KHZI2aqsxWc3sr3Bsjp/5Y3LBkMXZ7+Gad uwNBBVfurwY5GKjw47tuY29i97mHOu8= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-605-PKonFiPKMJmoi_Jnd6tcUQ-1; Thu, 30 Apr 2026 14:11:46 -0400 X-MC-Unique: PKonFiPKMJmoi_Jnd6tcUQ-1 X-Mimecast-MFC-AGG-ID: PKonFiPKMJmoi_Jnd6tcUQ_1777572705 Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-50faf575af4so26025441cf.0 for ; Thu, 30 Apr 2026 11:11:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777572705; x=1778177505; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lEHoETRm6gyxs0GbPIj+uCM9o6uEsTYwIm5rgODOr/s=; b=FY+KpXc8lz7ACq/PklyXf6uh1xdrjDKyXoqFDMc01N1Wvf3+V/DUuWJ/J/hmsUFOjK x0TgrbHfmmfyOl/7gpPQSlFYN1fajQUSoiDo+YO/Ejw4Ur3G9f4b/DmeWjlSrMbzAjJ2 Uc75Ci9W/Q4gYPxe7pIrbkCO2kTsy2oxmpwAxHEsvmQAGbhqyWOKd5nm46u+UpCcywAG Jw33RMOazM6GQnAAJYN8Ph1mTgfGg6y0UnYsc8pgv5D7RMoFBIajI6a+M8frK3QgwmFr DkKsp4K+ZavA6yolEMUWxjgBZoARDn2xtyvTdM8dozaKFzzjbyqq05IWka6p93syEUvp j8jg== X-Forwarded-Encrypted: i=1; AFNElJ9OYnc4zXZD52BXYWaiT+0OkEMGdH45XB+9kWn6RS/Xy9XnZs9L9iPLCb8qA6j74it34I/avTMVohDocg==@sourceware.org X-Gm-Message-State: AOJu0YyVuTSMXTKwFZP5kTUm81ylTsbBNXpFnQ0mNfgIjK/o5KRQTBvE +fu6JXIWiWZUtYDNjhdYKlTudtChRT2YsVj8s/2yoAqd4uq9L+5lM4ZG+wVy/cghiRdbvvPcM3z 5oc/Tgeeg78fFt8KzPxxT45PFxPzwfPL8jV5ULM+1JtMkVd104EPIeSMTRqiW7ZDJUt8I3wY= X-Gm-Gg: AeBDiesZ8Ufz4f6S3i+Ky/EyAhQaD0MR92UYoglJG/fDdtJVth7mBdy39ozGqpH3vT5 2vK6+uowMbueVH00U0KnPjoTlhHYJvBaI9zuZKALYFIo7fNd7D4k7kr0JTml8FtENJTnMoStnwE ZS0fv162tSjEZpX5gFG1osVzLJ4oumevveph8vDzAkUe9C19pnGQnYIYn9PTXCA0Nx/79cn0/Ir 7315ToOyYm/rAJ+gcpmmCd6o6rW3qfJ2hqYGbDttCPEqB60c2pMtJil0PyNN8bkeWHxqL2h/xbZ gJlWNOWZKksWdHD4rfDQvjjpHt/qP/NfjHe2N4VpO9WCEna7IxuITq1Rsw1AGgAtvVGlNwacH6n F6zFksJMSSKmzbkNylPKuqeB0RLJxAxHfVvcqk/k= X-Received: by 2002:a05:622a:1f09:b0:50d:a1c4:e154 with SMTP id d75a77b69052e-5102ae1da7fmr56671421cf.36.1777572700049; Thu, 30 Apr 2026 11:11:40 -0700 (PDT) X-Received: by 2002:a05:622a:1f09:b0:50d:a1c4:e154 with SMTP id d75a77b69052e-5102ae1da7fmr56670861cf.36.1777572699593; Thu, 30 Apr 2026 11:11:39 -0700 (PDT) Received: from [150.1.200.157] ([172.56.107.181]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-5103d1c6fc4sm1625331cf.4.2026.04.30.11.11.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Apr 2026 11:11:39 -0700 (PDT) Message-ID: <790c23b4-af98-4877-872d-2c92e134f6ca@redhat.com> Date: Thu, 30 Apr 2026 11:11:36 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb, btrace: support libipt v2.2 events To: Markus Metzger , gdb-patches@sourceware.org References: <20260430112428.1537534-1-markus.t.metzger@intel.com> From: Keith Seitz In-Reply-To: <20260430112428.1537534-1-markus.t.metzger@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: qv_gou5h7w3V5fLg--l_M39ApghSO2S_bVEN2VG2tfw_1777572705 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi, On 4/30/26 4:24 AM, Markus Metzger wrote: > --- > gdb/btrace.c | 53 ++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 53 insertions(+) There appears to be no commit message other than the (admittedly rather complete) title? I think a brief NEWS entry is warranted, too. There is one tiny nit (below), but otherwise, I think you should approve your patch. ;-) Reviewed-By: Keith Seitz Keith > > diff --git a/gdb/btrace.c b/gdb/btrace.c > index 6a8f0f549d1..f9c6f0e5b6a 100644 > --- a/gdb/btrace.c > +++ b/gdb/btrace.c > @@ -1597,6 +1597,59 @@ handle_pt_insn_events (struct btrace_thread_info *btinfo, > break; > } > #endif /* defined (LIBIPT_VERSION >= 0x201) */ > + > +#if (LIBIPT_VERSION >= 0x202) > + case ptev_trig: > + { > + std::string aux_string = std::string (_("trig: trbv = ")) > + + hex_string (event.variant.trig.trbv); > + > + if (event.variant.trig.mult != 0) > + aux_string += std::string (", mult"); > + > + if (event.ip_suppressed == 0) > + { > + pc = event.variant.trig.ip; > + aux_string += std::string (", ip = ") + hex_string (*pc); > + } > + > + if (event.variant.trig.icnt != 0) > + aux_string += std::string (", icnt = ") > + + hex_string (event.variant.trig.icnt); > + > + handle_pt_aux_insn (btinfo, aux_string, pc); > + break; > + } > + > + case ptev_swintr: > + { > + std::string aux_string = std::string (_("swintr: vector = ")) > + + hex_string (event.variant.swintr.vector); > + > + if (event.ip_suppressed == 0) > + { > + pc = event.variant.swintr.ip; > + aux_string += std::string (", ip = ") + hex_string (*pc); > + } > + > + handle_pt_aux_insn (btinfo, aux_string, pc); > + break; > + } > + > + case ptev_syscall: > + { > + std::string aux_string = std::string (_("syscall")); > + > + if (event.ip_suppressed == 0) > + { > + pc = event.variant.syscall.ip; > + aux_string += std::string (": ip = ") + hex_string (*pc); > + } > + > + handle_pt_aux_insn (btinfo, aux_string, pc); > + break; > + } > +#endif /* (LIBIPT_VERSION >= 0x202) */ Elsewhere in the file, this comment includes "defined". > } > } > #endif /* defined (HAVE_PT_INSN_EVENT) */