From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id vphBMI7E+GkGBRMAWB0awg (envelope-from ) for ; Mon, 04 May 2026 12:08:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1777910926; bh=yG+WrhSWPy4MMMb8FcFFEx+fOJPjTxlluoHVZhcvjdo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=tlfIB8y+f1uzuKi8r5CYsle5pw+/8GRuG/wNl30kILgMxxmYdL3m1eE+2Geddwukd rKOLdbFu8EVyA2/if4v0Frbnx9CsokNlTbwFVkg2bdPCjxksfo+VuqpJbi9cter/NZ zQJAyzeChKsi0cSg5W4TrWMFh9GCQ0CmdLNqPFLY= Received: by simark.ca (Postfix, from userid 112) id B7E9A1E0BA; Mon, 04 May 2026 12:08:46 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=sWmAU5IY; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 50B901E067 for ; Mon, 04 May 2026 12:08:46 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id DDEE94BABF09 for ; Mon, 4 May 2026 16:08:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DDEE94BABF09 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=sWmAU5IY Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id BAD954BA23D3 for ; Mon, 4 May 2026 16:08:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BAD954BA23D3 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BAD954BA23D3 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777910897; cv=none; b=LtP0ZKAk1jJK2kTkgyM7PTc/79RULFPaKvudMPDAz5eska7Nt0BBpvS8UGZb1QMGUvLZqZzIE3kmN2DIxu+Iv9TmQoDTFkjHCE/dGiLSV6mh1imvfPrO/JQxfpx61bBEIPw2GjvZEhM3o//IfBP+2BijX2Z3UKxjdMdEl7MV9LM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777910897; c=relaxed/simple; bh=yG+WrhSWPy4MMMb8FcFFEx+fOJPjTxlluoHVZhcvjdo=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=Sc8e4RxdaaRQQScifxaOIsoNB8ssJI28RquTUFh45aUoZ/ffoDVvJYXbQD7aS2g4SNwlLuQTtIUsQ+MSZZ5ABUsXhhnuidOIw1coVOvhUEKjMTwdc/u2l1oaVm35rOV1XUeluVE6KIHy0zAExA8hjDYk+n/HL83qi4pVhlmQMg0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BAD954BA23D3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1777910896; bh=yG+WrhSWPy4MMMb8FcFFEx+fOJPjTxlluoHVZhcvjdo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=sWmAU5IYS7ZumqGWi3WktXe9ZBqvpONzpwOpUO7HcibHCLEHgn0D6/f0PJQ6+7gmS VlFMAliYUu5DrKqfCKRn9mRy+KOZnKMblOT48O83HjTEeTuDo602+bTCwSGm6a1TqJ MTWSYBbYkGSbIhuSFfuyZAPTHYwkJ86KZSlyH2s4= Received: by simark.ca (Postfix) id B726C1E067; Mon, 04 May 2026 12:08:15 -0400 (EDT) Message-ID: Date: Mon, 4 May 2026 12:08:15 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb, btrace: support libipt v2.2 events To: "Metzger, Markus T" , Tom Tromey Cc: "gdb-patches@sourceware.org" , Keith Seitz References: <20260430112428.1537534-1-markus.t.metzger@intel.com> <790c23b4-af98-4877-872d-2c92e134f6ca@redhat.com> <87pl3fgk3j.fsf@tromey.com> Content-Language: fr From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 5/4/26 3:16 AM, Metzger, Markus T wrote: > Hello Tom, > >>>>>>> "Keith" == Keith Seitz writes: >> >>>> + std::string aux_string = std::string (_("trig: trbv = ")) >>>> + + hex_string (event.variant.trig.trbv); >> >> Normally here we'd wrap the RSH in parens, per the coding standards. > > I'd need to break at the =, then, like this: > > std::string aux_string > = (std::string (_("trig: trbv = ")) > + hex_string (event.variant.trig.trbv)); > > The patch matches the surrounding style, so if you want this fixed, I'd need > to fix it everywhere in a separate patch. Just noting that you could also use `string_printf` for this, which sometimes gives more readable code than using concatenation (and perhaps one day we'll use {fmt}/std::format, one can dream). Simon