Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Kai Tietz <Kai.Tietz@onevision.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: "Joel Brobecker" <brobecker@adacore.com>,
	gdb-patches@sourceware.org,
	        "Kai Tietz" <ktietz70@googlemail.com>
Subject: Re: [patch] Reading coff-pe-read files
Date: Fri, 09 Jan 2009 09:33:00 -0000	[thread overview]
Message-ID: <OF331390C1.20EEF488-ONC1257539.0033B1E2-C1257539.00346A12@onevision.de> (raw)
In-Reply-To: <200901090858.02600.pedro@codesourcery.com>

Pedro Alves <pedro@codesourcery.com> wrote on 09.01.2009 09:58:01:

> On Thursday 08 January 2009 20:55:13, Kai Tietz wrote:
> 
> > Thank you all. Patch committed.
> 
> Looks like the wrong version got in? :
> 
> .../../src/gdb/coff-pe-read.c: In function 'read_pe_exported_syms':
> ../../src/gdb/coff-pe-read.c:226: error: expected ')' before ';' token
> ../../src/gdb/coff-pe-read.c:358: error: expected ';' before '}' token
> 
> -- 
> Pedro Alves
> 
Hi Pedro,

Sorry, I missed one ending frame. Committed as obvious.

2009-01-08  Kai Tietz  <kai.tietz@onevision.com>

        * coff-pe-read.c (read_pe_exported_syms): Fix typo.

Thanks,
Kai

-----
Index: coff-pe-read.c
===================================================================
RCS file: /cvs/src/src/gdb/coff-pe-read.c,v
retrieving revision 1.9
diff -u -r1.9 coff-pe-read.c
--- coff-pe-read.c      8 Jan 2009 20:53:32 -0000       1.9
+++ coff-pe-read.c      9 Jan 2009 09:31:19 -0000
@@ -223,7 +223,7 @@
   pe_header_offset = pe_get32 (dll, 0x3c);
   opthdr_ofs = pe_header_offset + 4 + 20;
   if (is_pe64)
-    num_entries = pe_get32 (dll, opthdr_ofs + 108;
+    num_entries = pe_get32 (dll, opthdr_ofs + 108);
   else
     num_entries = pe_get32 (dll, opthdr_ofs + 92);


  reply	other threads:[~2009-01-09  9:33 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-07 13:51 Kai Tietz
2009-01-08  9:53 ` Joel Brobecker
2009-01-08 10:23   ` Kai Tietz
2009-01-08 11:10     ` Joel Brobecker
2009-01-08 12:53       ` Kai Tietz
2009-01-08 12:58         ` Joel Brobecker
2009-01-08 13:09           ` Joel Brobecker
2009-01-08 13:37             ` Kai Tietz
2009-01-08 20:07           ` Christopher Faylor
2009-01-08 20:55             ` Kai Tietz
2009-01-09  8:58               ` Pedro Alves
2009-01-09  9:33                 ` Kai Tietz [this message]
2009-01-08 10:36   ` Pierre Muller
  -- strict thread matches above, loose matches on Subject: below --
2009-01-07 12:27 [RFA/commit] arch-utils.c: Use host_address_to_string when printing function addresses Joel Brobecker
2009-01-07 13:15 ` [patch] Reading coff-pe-read files Kai Tietz
2009-01-07 13:54   ` Pierre Muller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OF331390C1.20EEF488-ONC1257539.0033B1E2-C1257539.00346A12@onevision.de \
    --to=kai.tietz@onevision.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=ktietz70@googlemail.com \
    --cc=pedro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox