From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org
Subject: [RFA/commit] arch-utils.c: Use host_address_to_string when printing function addresses
Date: Wed, 07 Jan 2009 12:27:00 -0000 [thread overview]
Message-ID: <20090107122701.GJ1751@adacore.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 451 bytes --]
Similar to what I did in gdbarch.sh/gdbarch.c, this patch uses
host_address_to_string to transform addresses into strings, rather
than printing them as longs...
2009-01-07 Joel Brobecker <brobecker@adacore.com>
* arch-utils.c (gdbarch_update_p): Use host_address_to_string
to print the address of the gdbarch pointer.
Tested on x86-linux. Will commit at the same time as the gdbarch.sh
patch if there are no objections.
--
Joel
[-- Attachment #2: arch-utils.diff --]
[-- Type: text/plain, Size: 995 bytes --]
diff --git a/gdb/arch-utils.c b/gdb/arch-utils.c
index 41c4933..c1ea9da 100644
--- a/gdb/arch-utils.c
+++ b/gdb/arch-utils.c
@@ -495,8 +495,8 @@ gdbarch_update_p (struct gdbarch_info info)
{
if (gdbarch_debug)
fprintf_unfiltered (gdb_stdlog, "gdbarch_update_p: "
- "Architecture 0x%08lx (%s) unchanged\n",
- (long) new_gdbarch,
+ "Architecture %s (%s) unchanged\n",
+ host_address_to_string (new_gdbarch),
gdbarch_bfd_arch_info (new_gdbarch)->printable_name);
return 1;
}
@@ -504,8 +504,8 @@ gdbarch_update_p (struct gdbarch_info info)
/* It's a new architecture, swap it in. */
if (gdbarch_debug)
fprintf_unfiltered (gdb_stdlog, "gdbarch_update_p: "
- "New architecture 0x%08lx (%s) selected\n",
- (long) new_gdbarch,
+ "New architecture %s (%s) selected\n",
+ host_address_to_string (new_gdbarch),
gdbarch_bfd_arch_info (new_gdbarch)->printable_name);
deprecated_current_gdbarch_select_hack (new_gdbarch);
next reply other threads:[~2009-01-07 12:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-07 12:27 Joel Brobecker [this message]
2009-01-07 13:15 ` [patch] Reading coff-pe-read files Kai Tietz
2009-01-07 13:54 ` Pierre Muller
2009-01-09 11:09 ` [RFA/commit] arch-utils.c: Use host_address_to_string when printing function addresses Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090107122701.GJ1751@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox