RE: [patch] Reading coff-pe-read files

Pierre Muller
2009-01-07T13:54:33Z

Should this be transformed so that we can also
correctly cross-read 64-bit PE files
on 32-bit and vice-versa?

Possibly by defining an extra offset
that would be set to 16 if target is "pe-x86-64" or "pei-x86-64"
and to zero otherwise?

Pierre Muller
Pascal language support maintainer for GDB

> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Kai Tietz
> Envoyé : Wednesday, January 07, 2009 2:15 PM
> À : Joel Brobecker
> Cc : gdb-patches@sourceware.org
> Objet : [patch] Reading coff-pe-read files
>
> Hi,
>
> One small piece for x86_64 windows support in coff-pe-read.c seems to
> be missing. In function read_pe_exported_syms wrong indexes are used to
> find exports of the image.
> The source uses here the same pattern as in bfd/pe-dll.c.
>
> ChangeLog
>
> 2009-01-07 Kai Tietz <kai.tietz@onevision.com>
>
> * coff-pe-read.c (read_pe_exported_syms): Enable read of PE+
> export directory.
>
>
> I am uncertain, which macro I should use here (or if it would be better
> to
> make for PE+ a copy of this file), so I used _WIN64 as condition.
>
> Cheers,
> Kai
>
> PS: I have already papers ready with FSF for gdb, so there shouldn't be
> any problem about taking parts of my donated code, I've provided to
> Joel
> IMHO.
>
>
>
> | (\_/) This is Bunny. Copy and paste Bunny
> | (='.'=) into your signature to help him gain
> | (")_(") world domination.