From: Kai Tietz <Kai.Tietz@onevision.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: [patch] Reading coff-pe-read files
Date: Wed, 07 Jan 2009 13:15:00 -0000 [thread overview]
Message-ID: <OFB1459990.B6D7FE2C-ONC1257537.0046DD2E-C1257537.0048CC7E@onevision.de> (raw)
In-Reply-To: <20090107122701.GJ1751@adacore.com>
[-- Attachment #1: Type: text/plain, Size: 820 bytes --]
Hi,
One small piece for x86_64 windows support in coff-pe-read.c seems to be
missing. In function read_pe_exported_syms wrong indexes are used to find
exports of the image.
The source uses here the same pattern as in bfd/pe-dll.c.
ChangeLog
2009-01-07 Kai Tietz <kai.tietz@onevision.com>
* coff-pe-read.c (read_pe_exported_syms): Enable read of PE+
export directory.
I am uncertain, which macro I should use here (or if it would be better to
make for PE+ a copy of this file), so I used _WIN64 as condition.
Cheers,
Kai
PS: I have already papers ready with FSF for gdb, so there shouldn't be
any problem about taking parts of my donated code, I've provided to Joel
IMHO.
| (\_/) This is Bunny. Copy and paste Bunny
| (='.'=) into your signature to help him gain
| (")_(") world domination.
[-- Attachment #2: pe-coff-read.diff --]
[-- Type: application/octet-stream, Size: 1503 bytes --]
Index: src/gdb/coff-pe-read.c
===================================================================
--- src.orig/gdb/coff-pe-read.c
+++ src/gdb/coff-pe-read.c
@@ -205,7 +205,10 @@ read_pe_exported_syms (struct objfile *o
char const *target = bfd_get_target (objfile->obfd);
- if ((strcmp (target, "pe-i386") != 0) && (strcmp (target, "pei-i386") != 0))
+ if ((strcmp (target, "pe-i386") != 0)
+ && (strcmp (target, "pei-i386") != 0)
+ && (strcmp (target, "pe-x86-64") != 0)
+ && (strcmp (target, "pei-x86-64") != 0))
{
/* This is not an i386 format file. Abort now, because the code
is untested on anything else. *FIXME* test on further
@@ -216,15 +219,24 @@ read_pe_exported_syms (struct objfile *o
/* Get pe_header, optional header and numbers of export entries. */
pe_header_offset = pe_get32 (dll, 0x3c);
opthdr_ofs = pe_header_offset + 4 + 20;
+#ifdef _WIN64
+ num_entries = pe_get32 (dll, opthdr_ofs + 92 + 16);
+#else
num_entries = pe_get32 (dll, opthdr_ofs + 92);
+#endif
if (num_entries < 1) /* No exports. */
{
return;
}
+#ifdef _WIN64
+ export_rva = pe_get32 (dll, opthdr_ofs + 96 + 16);
+ export_size = pe_get32 (dll, opthdr_ofs + 100 + 16);
+#else
export_rva = pe_get32 (dll, opthdr_ofs + 96);
export_size = pe_get32 (dll, opthdr_ofs + 100);
+#endif
nsections = pe_get16 (dll, pe_header_offset + 4 + 2);
secptr = (pe_header_offset + 4 + 20 +
pe_get16 (dll, pe_header_offset + 4 + 16));
next prev parent reply other threads:[~2009-01-07 13:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-07 12:27 [RFA/commit] arch-utils.c: Use host_address_to_string when printing function addresses Joel Brobecker
2009-01-07 13:15 ` Kai Tietz [this message]
2009-01-07 13:54 ` [patch] Reading coff-pe-read files Pierre Muller
2009-01-09 11:09 ` [RFA/commit] arch-utils.c: Use host_address_to_string when printing function addresses Joel Brobecker
2009-01-07 13:51 [patch] Reading coff-pe-read files Kai Tietz
2009-01-08 9:53 ` Joel Brobecker
2009-01-08 10:23 ` Kai Tietz
2009-01-08 11:10 ` Joel Brobecker
2009-01-08 12:53 ` Kai Tietz
2009-01-08 12:58 ` Joel Brobecker
2009-01-08 13:09 ` Joel Brobecker
2009-01-08 13:37 ` Kai Tietz
2009-01-08 20:07 ` Christopher Faylor
2009-01-08 20:55 ` Kai Tietz
2009-01-09 8:58 ` Pedro Alves
2009-01-09 9:33 ` Kai Tietz
2009-01-08 10:36 ` Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OFB1459990.B6D7FE2C-ONC1257537.0046DD2E-C1257537.0048CC7E@onevision.de \
--to=kai.tietz@onevision.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox