From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17860 invoked by alias); 7 Jan 2009 13:15:47 -0000 Received: (qmail 17839 invoked by uid 22791); 7 Jan 2009 13:15:46 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from outdoor.onevision.de (HELO outdoor.onevision.de) (212.77.172.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 07 Jan 2009 13:15:42 +0000 Received: from sanders.onevision.de (moonrace [212.77.172.62]) by outdoor.onevision.de (8.14.3/8.13.7/ROSCH/DDB) with ESMTP id n07DFBBc025006; Wed, 7 Jan 2009 14:15:16 +0100 In-Reply-To: <20090107122701.GJ1751@adacore.com> To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: [patch] Reading coff-pe-read files MIME-Version: 1.0 Message-ID: From: Kai Tietz Date: Wed, 07 Jan 2009 13:15:00 -0000 Content-Type: multipart/mixed; boundary="=_mixed 0048CC77C1257537_=" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-01/txt/msg00094.txt.bz2 --=_mixed 0048CC77C1257537_= Content-Type: text/plain; charset="US-ASCII" Content-length: 820 Hi, One small piece for x86_64 windows support in coff-pe-read.c seems to be missing. In function read_pe_exported_syms wrong indexes are used to find exports of the image. The source uses here the same pattern as in bfd/pe-dll.c. ChangeLog 2009-01-07 Kai Tietz * coff-pe-read.c (read_pe_exported_syms): Enable read of PE+ export directory. I am uncertain, which macro I should use here (or if it would be better to make for PE+ a copy of this file), so I used _WIN64 as condition. Cheers, Kai PS: I have already papers ready with FSF for gdb, so there shouldn't be any problem about taking parts of my donated code, I've provided to Joel IMHO. | (\_/) This is Bunny. Copy and paste Bunny | (='.'=) into your signature to help him gain | (")_(") world domination. --=_mixed 0048CC77C1257537_= Content-Type: application/octet-stream; name="pe-coff-read.diff" Content-Disposition: attachment; filename="pe-coff-read.diff" Content-Transfer-Encoding: base64 Content-length: 2038 SW5kZXg6IHNyYy9nZGIvY29mZi1wZS1yZWFkLmMKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gc3JjLm9yaWcvZ2RiL2NvZmYtcGUtcmVhZC5jCisrKyBz cmMvZ2RiL2NvZmYtcGUtcmVhZC5jCkBAIC0yMDUsNyArMjA1LDEwIEBAIHJl YWRfcGVfZXhwb3J0ZWRfc3ltcyAoc3RydWN0IG9iamZpbGUgKm8KIAogICBj aGFyIGNvbnN0ICp0YXJnZXQgPSBiZmRfZ2V0X3RhcmdldCAob2JqZmlsZS0+ b2JmZCk7CiAKLSAgaWYgKChzdHJjbXAgKHRhcmdldCwgInBlLWkzODYiKSAh PSAwKSAmJiAoc3RyY21wICh0YXJnZXQsICJwZWktaTM4NiIpICE9IDApKQor ICBpZiAoKHN0cmNtcCAodGFyZ2V0LCAicGUtaTM4NiIpICE9IDApCisgICAg ICAmJiAoc3RyY21wICh0YXJnZXQsICJwZWktaTM4NiIpICE9IDApCisgICAg ICAmJiAoc3RyY21wICh0YXJnZXQsICJwZS14ODYtNjQiKSAhPSAwKQorICAg ICAgJiYgKHN0cmNtcCAodGFyZ2V0LCAicGVpLXg4Ni02NCIpICE9IDApKQog ICAgIHsKICAgICAgIC8qIFRoaXMgaXMgbm90IGFuIGkzODYgZm9ybWF0IGZp bGUuIEFib3J0IG5vdywgYmVjYXVzZSB0aGUgY29kZQogICAgICAgICAgaXMg dW50ZXN0ZWQgb24gYW55dGhpbmcgZWxzZS4gKkZJWE1FKiB0ZXN0IG9uIGZ1 cnRoZXIKQEAgLTIxNiwxNSArMjE5LDI0IEBAIHJlYWRfcGVfZXhwb3J0ZWRf c3ltcyAoc3RydWN0IG9iamZpbGUgKm8KICAgLyogR2V0IHBlX2hlYWRlciwg b3B0aW9uYWwgaGVhZGVyIGFuZCBudW1iZXJzIG9mIGV4cG9ydCBlbnRyaWVz LiAgKi8KICAgcGVfaGVhZGVyX29mZnNldCA9IHBlX2dldDMyIChkbGwsIDB4 M2MpOwogICBvcHRoZHJfb2ZzID0gcGVfaGVhZGVyX29mZnNldCArIDQgKyAy MDsKKyNpZmRlZiBfV0lONjQKKyAgbnVtX2VudHJpZXMgPSBwZV9nZXQzMiAo ZGxsLCBvcHRoZHJfb2ZzICsgOTIgKyAxNik7CisjZWxzZQogICBudW1fZW50 cmllcyA9IHBlX2dldDMyIChkbGwsIG9wdGhkcl9vZnMgKyA5Mik7CisjZW5k aWYKIAogICBpZiAobnVtX2VudHJpZXMgPCAxKQkJLyogTm8gZXhwb3J0cy4g ICovCiAgICAgewogICAgICAgcmV0dXJuOwogICAgIH0KIAorI2lmZGVmIF9X SU42NAorICBleHBvcnRfcnZhID0gcGVfZ2V0MzIgKGRsbCwgb3B0aGRyX29m cyArIDk2ICsgMTYpOworICBleHBvcnRfc2l6ZSA9IHBlX2dldDMyIChkbGws IG9wdGhkcl9vZnMgKyAxMDAgKyAxNik7CisjZWxzZQogICBleHBvcnRfcnZh ID0gcGVfZ2V0MzIgKGRsbCwgb3B0aGRyX29mcyArIDk2KTsKICAgZXhwb3J0 X3NpemUgPSBwZV9nZXQzMiAoZGxsLCBvcHRoZHJfb2ZzICsgMTAwKTsKKyNl bmRpZgogICBuc2VjdGlvbnMgPSBwZV9nZXQxNiAoZGxsLCBwZV9oZWFkZXJf b2Zmc2V0ICsgNCArIDIpOwogICBzZWNwdHIgPSAocGVfaGVhZGVyX29mZnNl dCArIDQgKyAyMCArCiAJICAgIHBlX2dldDE2IChkbGwsIHBlX2hlYWRlcl9v ZmZzZXQgKyA0ICsgMTYpKTsK --=_mixed 0048CC77C1257537_=--