Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Kai Tietz <Kai.Tietz@onevision.com>
To: gdb-patches@sourceware.org
Cc: Joel Brobecker <brobecker@adacore.com>
Subject: Re: [patch] Reading coff-pe-read files
Date: Wed, 07 Jan 2009 13:51:00 -0000	[thread overview]
Message-ID: <OF85EF0545.1B50FC45-ONC1257537.004BFB3B-C1257537.004C1B6A@onevision.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 214 bytes --]

Hello,

I modified my patch, so that it doesn't need a #if clause anymore.


Cheers,
Kai



|  (\_/)  This is Bunny. Copy and paste Bunny
| (='.'=) into your signature to help him gain
| (")_(") world domination.


[-- Attachment #2: pe-coff-read.diff --]
[-- Type: application/octet-stream, Size: 2049 bytes --]

Index: src/gdb/coff-pe-read.c
===================================================================
--- src.orig/gdb/coff-pe-read.c
+++ src/gdb/coff-pe-read.c
@@ -191,6 +191,8 @@ read_pe_exported_syms (struct objfile *o
   unsigned char *expdata, *erva;
   unsigned long name_rvas, ordinals, nexp, ordbase;
   char *dll_name;
+  int be64 = 0;
+  int be32 = 0;
 
   /* Array elements are for text, data and bss in that order
      Initialization with start_rva > end_rva guarantees that
@@ -205,7 +207,11 @@ read_pe_exported_syms (struct objfile *o
 
   char const *target = bfd_get_target (objfile->obfd);
 
-  if ((strcmp (target, "pe-i386") != 0) && (strcmp (target, "pei-i386") != 0))
+  be64 = ((strcmp (target, "pe-x86-64") == 0)
+         || ((strcmp (target, "pei-x86-64") == 0));
+  be32 = ((strcmp (target, "pe-i386") == 0)
+          || (strcmp (target, "pei-i386") == 0));
+  if (!be32 && !be64)
     {
       /* This is not an i386 format file. Abort now, because the code
          is untested on anything else. *FIXME* test on further
@@ -216,15 +222,26 @@ read_pe_exported_syms (struct objfile *o
   /* Get pe_header, optional header and numbers of export entries.  */
   pe_header_offset = pe_get32 (dll, 0x3c);
   opthdr_ofs = pe_header_offset + 4 + 20;
-  num_entries = pe_get32 (dll, opthdr_ofs + 92);
+  if (be64)
+    num_entries = pe_get32 (dll, opthdr_ofs + 92 + 16);
+  else
+    num_entries = pe_get32 (dll, opthdr_ofs + 92);
 
   if (num_entries < 1)		/* No exports.  */
     {
       return;
     }
 
-  export_rva = pe_get32 (dll, opthdr_ofs + 96);
-  export_size = pe_get32 (dll, opthdr_ofs + 100);
+  if (be64)
+    {
+      export_rva = pe_get32 (dll, opthdr_ofs + 96 + 16);
+      export_size = pe_get32 (dll, opthdr_ofs + 100 + 16);
+    }
+  else
+    {
+      export_rva = pe_get32 (dll, opthdr_ofs + 96);
+      export_size = pe_get32 (dll, opthdr_ofs + 100);
+    }
   nsections = pe_get16 (dll, pe_header_offset + 4 + 2);
   secptr = (pe_header_offset + 4 + 20 +
 	    pe_get16 (dll, pe_header_offset + 4 + 16));

             reply	other threads:[~2009-01-07 13:51 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-07 13:51 Kai Tietz [this message]
2009-01-08  9:53 ` Joel Brobecker
2009-01-08 10:23   ` Kai Tietz
2009-01-08 11:10     ` Joel Brobecker
2009-01-08 12:53       ` Kai Tietz
2009-01-08 12:58         ` Joel Brobecker
2009-01-08 13:09           ` Joel Brobecker
2009-01-08 13:37             ` Kai Tietz
2009-01-08 20:07           ` Christopher Faylor
2009-01-08 20:55             ` Kai Tietz
2009-01-09  8:58               ` Pedro Alves
2009-01-09  9:33                 ` Kai Tietz
2009-01-08 10:36   ` Pierre Muller
  -- strict thread matches above, loose matches on Subject: below --
2009-01-07 12:27 [RFA/commit] arch-utils.c: Use host_address_to_string when printing function addresses Joel Brobecker
2009-01-07 13:15 ` [patch] Reading coff-pe-read files Kai Tietz
2009-01-07 13:54   ` Pierre Muller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OF85EF0545.1B50FC45-ONC1257537.004BFB3B-C1257537.004C1B6A@onevision.de \
    --to=kai.tietz@onevision.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox