From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21114 invoked by alias); 9 Jan 2009 09:33:23 -0000 Received: (qmail 21105 invoked by uid 22791); 9 Jan 2009 09:33:22 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from outdoor.onevision.de (HELO outdoor.onevision.de) (212.77.172.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 09 Jan 2009 09:33:07 +0000 Received: from sanders.onevision.de (moonrace [212.77.172.62]) by outdoor.onevision.de (8.14.3/8.13.7/ROSCH/DDB) with ESMTP id n099WYvv018830; Fri, 9 Jan 2009 10:32:39 +0100 In-Reply-To: <200901090858.02600.pedro@codesourcery.com> To: Pedro Alves Cc: "Joel Brobecker" , gdb-patches@sourceware.org, "Kai Tietz" Subject: Re: [patch] Reading coff-pe-read files MIME-Version: 1.0 Message-ID: From: Kai Tietz Date: Fri, 09 Jan 2009 09:33:00 -0000 Content-Type: text/plain; charset="US-ASCII" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-01/txt/msg00177.txt.bz2 Pedro Alves wrote on 09.01.2009 09:58:01: > On Thursday 08 January 2009 20:55:13, Kai Tietz wrote: > > > Thank you all. Patch committed. > > Looks like the wrong version got in? : > > .../../src/gdb/coff-pe-read.c: In function 'read_pe_exported_syms': > ../../src/gdb/coff-pe-read.c:226: error: expected ')' before ';' token > ../../src/gdb/coff-pe-read.c:358: error: expected ';' before '}' token > > -- > Pedro Alves > Hi Pedro, Sorry, I missed one ending frame. Committed as obvious. 2009-01-08 Kai Tietz * coff-pe-read.c (read_pe_exported_syms): Fix typo. Thanks, Kai ----- Index: coff-pe-read.c =================================================================== RCS file: /cvs/src/src/gdb/coff-pe-read.c,v retrieving revision 1.9 diff -u -r1.9 coff-pe-read.c --- coff-pe-read.c 8 Jan 2009 20:53:32 -0000 1.9 +++ coff-pe-read.c 9 Jan 2009 09:31:19 -0000 @@ -223,7 +223,7 @@ pe_header_offset = pe_get32 (dll, 0x3c); opthdr_ofs = pe_header_offset + 4 + 20; if (is_pe64) - num_entries = pe_get32 (dll, opthdr_ofs + 108; + num_entries = pe_get32 (dll, opthdr_ofs + 108); else num_entries = pe_get32 (dll, opthdr_ofs + 92);