Re: [patch] Reading coff-pe-read files

Joel Brobecker
2009-01-08T13:09:19Z

> > > > 2009-01-08 Kai Tietz <kai.tietz@onevision.com>
> > > >
> > > > * coff-pe-read.c (read_pe_exported_syms): Enable read of PE+
> > > > export directory.
>
> Approved.

Actually, the compiler just spotted a couple of syntax errors.
GASP! We should have both been more careful.
Can you please fix them before checking in?

> - if ((strcmp (target, "pe-i386") != 0) && (strcmp (target, "pei-i386") != 0))
> + is_pe64 = ((strcmp (target, "pe-x86-64") == 0)
> + || ((strcmp (target, "pei-x86-64") == 0));
^^ One '(' too many here.

Also, I can never determine in diffs whether the weird formatting
is because of tabs or because it is wrong. But in this case,
the "||" is put at the wrong location. I know it looks nicer if
the two strcmp expressions are aligned, but any formatter will
destroy that, and we do use GNU indent once in a while. So let's
be consistent and format the above as follow:

> + is_pe64 = ((strcmp (target, "pe-x86-64") == 0)
> + || ((strcmp (target, "pei-x86-64") == 0));

Same for is_pe32.

> + if (is_pe64)
> + num_entries = pe_get32 (dll, opthdr_ofs + 108;
^^
missing ')' here.

Thanks,
--
Joel