Re: Oh dear. I regret to inform you that commit 'remove param "dispp" from ada-lang.c::ada_lookup_struct_elt_type' might be unfortunate

Re: Oh dear. I regret to inform you that commit 'remove param "dispp" from ada-lang.c::ada_lookup_struct_elt_type' might be unfortunate

[Joel Brobecker]

Hello,

On Fri, Aug 25, 2017 at 08:48:58PM -0400, gdb-buildbot@sergiodj.net wrote:
> My lords, ladies, gentlemen, members of the public.
> 
> It is a matter of great regret and sadness to inform you that commit:
> 
> 	remove param "dispp" from ada-lang.c::ada_lookup_struct_elt_type
> 	988f6b3dc615173d6d78a76ac26c109b4582da74
> 
> might have made GDB unwell.  Since I am just your Butler BuildBot,
> I kindly ask that a human superior officer double-check this.

My change only touches a static function in ada-lang.c, while
the error is reported inside sparc64-tdep.  Maybe an earlier commit?

-- 
Joel

Re: Oh dear. I regret to inform you that commit 'remove param "dispp" from ada-lang.c::ada_lookup_struct_elt_type' might be unfortunate

[Simon Marchi]

On 2017-08-26 14:39, Joel Brobecker wrote:
> Hello,
> 
> On Fri, Aug 25, 2017 at 08:48:58PM -0400, gdb-buildbot@sergiodj.net 
> wrote:
>> My lords, ladies, gentlemen, members of the public.
>> 
>> It is a matter of great regret and sadness to inform you that commit:
>> 
>> 	remove param "dispp" from ada-lang.c::ada_lookup_struct_elt_type
>> 	988f6b3dc615173d6d78a76ac26c109b4582da74
>> 
>> might have made GDB unwell.  Since I am just your Butler BuildBot,
>> I kindly ask that a human superior officer double-check this.
> 
> My change only touches a static function in ada-lang.c, while
> the error is reported inside sparc64-tdep.  Maybe an earlier commit?

Yes, it was an earlier commit.  Weimin Pan has submitted patches to fix 
it, the latest version (needs to be reviewed) being:

   https://sourceware.org/ml/gdb-patches/2017-08/msg00495.html

Simon

Re: Oh dear. I regret to inform you that commit 'remove param "dispp" from ada-lang.c::ada_lookup_struct_elt_type' might be unfortunate

[Sergio Durigan Junior]

On Saturday, August 26 2017, Joel Brobecker wrote:

> Hello,
>
> On Fri, Aug 25, 2017 at 08:48:58PM -0400, gdb-buildbot@sergiodj.net wrote:
>> My lords, ladies, gentlemen, members of the public.
>> 
>> It is a matter of great regret and sadness to inform you that commit:
>> 
>> 	remove param "dispp" from ada-lang.c::ada_lookup_struct_elt_type
>> 	988f6b3dc615173d6d78a76ac26c109b4582da74
>> 
>> might have made GDB unwell.  Since I am just your Butler BuildBot,
>> I kindly ask that a human superior officer double-check this.
>
> My change only touches a static function in ada-lang.c, while
> the error is reported inside sparc64-tdep.  Maybe an earlier commit?

Yeah, sorry about these messages.  BuildBot is currently not smart
enough to figure out that the failure was not introduced by the last
commit.  One solution, proposed by Pedro, is to send the breakage e-mail
to the authors of all commits that haven't been tested until the last
one, but that's also not easy to do...  I'll investigate and see if
there's any other way.

Thanks,

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/

Re: Oh dear. I regret to inform you that commit 'remove param "dispp" from ada-lang.c::ada_lookup_struct_elt_type' might be unfortunate

[H.J. Lu]

On Sat, Aug 26, 2017 at 12:53 PM, Sergio Durigan Junior
<sergiodj@redhat.com> wrote:
> On Saturday, August 26 2017, Joel Brobecker wrote:
>
>> Hello,
>>
>> On Fri, Aug 25, 2017 at 08:48:58PM -0400, gdb-buildbot@sergiodj.net wrote:
>>> My lords, ladies, gentlemen, members of the public.
>>>
>>> It is a matter of great regret and sadness to inform you that commit:
>>>
>>>      remove param "dispp" from ada-lang.c::ada_lookup_struct_elt_type
>>>      988f6b3dc615173d6d78a76ac26c109b4582da74
>>>
>>> might have made GDB unwell.  Since I am just your Butler BuildBot,
>>> I kindly ask that a human superior officer double-check this.
>>
>> My change only touches a static function in ada-lang.c, while
>> the error is reported inside sparc64-tdep.  Maybe an earlier commit?
>
> Yeah, sorry about these messages.  BuildBot is currently not smart
> enough to figure out that the failure was not introduced by the last
> commit.  One solution, proposed by Pedro, is to send the breakage e-mail
> to the authors of all commits that haven't been tested until the last
> one, but that's also not easy to do...  I'll investigate and see if
> there's any other way.
>

You can keep track of errors for the current commit and do
not send an email if the next commit doesn't change errors.

-- 
H.J.