From: Simon Marchi <simon.marchi@polymtl.ca>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Oh dear. I regret to inform you that commit 'remove param "dispp" from ada-lang.c::ada_lookup_struct_elt_type' might be unfortunate
Date: Sat, 26 Aug 2017 13:18:00 -0000 [thread overview]
Message-ID: <7c3d3b9867cb06e5502ccca203e15da1@polymtl.ca> (raw)
In-Reply-To: <20170826123906.wg5s7qsm65lklk5s@adacore.com>
On 2017-08-26 14:39, Joel Brobecker wrote:
> Hello,
>
> On Fri, Aug 25, 2017 at 08:48:58PM -0400, gdb-buildbot@sergiodj.net
> wrote:
>> My lords, ladies, gentlemen, members of the public.
>>
>> It is a matter of great regret and sadness to inform you that commit:
>>
>> remove param "dispp" from ada-lang.c::ada_lookup_struct_elt_type
>> 988f6b3dc615173d6d78a76ac26c109b4582da74
>>
>> might have made GDB unwell. Since I am just your Butler BuildBot,
>> I kindly ask that a human superior officer double-check this.
>
> My change only touches a static function in ada-lang.c, while
> the error is reported inside sparc64-tdep. Maybe an earlier commit?
Yes, it was an earlier commit. Weimin Pan has submitted patches to fix
it, the latest version (needs to be reviewed) being:
https://sourceware.org/ml/gdb-patches/2017-08/msg00495.html
Simon
next prev parent reply other threads:[~2017-08-26 13:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1dlPHW-0007LM-Eg@kwanyin.sergiodj.net>
2017-08-26 12:39 ` Joel Brobecker
2017-08-26 13:18 ` Simon Marchi [this message]
2017-08-26 19:54 ` Sergio Durigan Junior
2017-08-26 21:04 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c3d3b9867cb06e5502ccca203e15da1@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox