From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 130440 invoked by alias); 26 Aug 2017 13:18:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 129820 invoked by uid 89); 26 Aug 2017 13:18:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:983, officer, dear, kindly X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 26 Aug 2017 13:18:46 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id v7QDIeC0029885 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sat, 26 Aug 2017 09:18:44 -0400 Received: by simark.ca (Postfix, from userid 112) id 0887E1EA24; Sat, 26 Aug 2017 09:18:40 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 5E0D01E988; Sat, 26 Aug 2017 09:18:28 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sat, 26 Aug 2017 13:18:00 -0000 From: Simon Marchi To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: Oh dear. I regret to inform you that commit 'remove param "dispp" from ada-lang.c::ada_lookup_struct_elt_type' might be unfortunate In-Reply-To: <20170826123906.wg5s7qsm65lklk5s@adacore.com> References: <20170826123906.wg5s7qsm65lklk5s@adacore.com> Message-ID: <7c3d3b9867cb06e5502ccca203e15da1@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.0 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sat, 26 Aug 2017 13:18:40 +0000 X-IsSubscribed: yes X-SW-Source: 2017-08/txt/msg00498.txt.bz2 On 2017-08-26 14:39, Joel Brobecker wrote: > Hello, > > On Fri, Aug 25, 2017 at 08:48:58PM -0400, gdb-buildbot@sergiodj.net > wrote: >> My lords, ladies, gentlemen, members of the public. >> >> It is a matter of great regret and sadness to inform you that commit: >> >> remove param "dispp" from ada-lang.c::ada_lookup_struct_elt_type >> 988f6b3dc615173d6d78a76ac26c109b4582da74 >> >> might have made GDB unwell. Since I am just your Butler BuildBot, >> I kindly ask that a human superior officer double-check this. > > My change only touches a static function in ada-lang.c, while > the error is reported inside sparc64-tdep. Maybe an earlier commit? Yes, it was an earlier commit. Weimin Pan has submitted patches to fix it, the latest version (needs to be reviewed) being: https://sourceware.org/ml/gdb-patches/2017-08/msg00495.html Simon