From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13093 invoked by alias); 26 Aug 2017 21:04:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13081 invoked by uid 89); 26 Aug 2017 21:04:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=officer, dear, kindly X-HELO: mail-oi0-f65.google.com Received: from mail-oi0-f65.google.com (HELO mail-oi0-f65.google.com) (209.85.218.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 26 Aug 2017 21:04:52 +0000 Received: by mail-oi0-f65.google.com with SMTP id k77so2650387oib.1 for ; Sat, 26 Aug 2017 14:04:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ZE7ts9CKp8LUfN3uJtJx2wn4BsFHUgUY5Nyo6LMJqHw=; b=TBm5/sVlrdnEVMMxa57xLf2I1V5AWxLm9HyvBYbkPGS1aoCjTenGdJV2rt1BUxeLCy WDNeczi0C+FvFGIjhiiPZgzYU5qRLsNoqgRUxRhIMagRDeB8GsCcOnZLVh9S3oqa2BsK GThGj3VERp11ei1a5mTMVWeDKF+YrOMpuJeJPyvPJTvqpXAzyGSqVbsEhwAVwMfVO+kv f/eBaqTGYLRvtY8gxp/qrEjHtJtml9SlV+3cAG3WvbyWSHGkOe8kKYcwO61o7sut/rVZ 3fA2Ui9BaPd9+i9HS1YvpBxpnTC9rVnyDeaTeWwda+Qq90dULO8wSQaSjinbBnPw0bXa zmgA== X-Gm-Message-State: AHYfb5h6IsuQS6iL7YBvS4vDtladY56TysbKCrBpIP+S8w9ECLP/TypA Cz1z/DzeiE2Gs1556em4r8vu3Kwgv875 X-Received: by 10.202.179.85 with SMTP id c82mr3011432oif.5.1503781490591; Sat, 26 Aug 2017 14:04:50 -0700 (PDT) MIME-Version: 1.0 Received: by 10.74.136.75 with HTTP; Sat, 26 Aug 2017 14:04:50 -0700 (PDT) In-Reply-To: <87mv6m9kbt.fsf@redhat.com> References: <20170826123906.wg5s7qsm65lklk5s@adacore.com> <87mv6m9kbt.fsf@redhat.com> From: "H.J. Lu" Date: Sat, 26 Aug 2017 21:04:00 -0000 Message-ID: Subject: Re: Oh dear. I regret to inform you that commit 'remove param "dispp" from ada-lang.c::ada_lookup_struct_elt_type' might be unfortunate To: Sergio Durigan Junior Cc: Joel Brobecker , GDB Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2017-08/txt/msg00500.txt.bz2 On Sat, Aug 26, 2017 at 12:53 PM, Sergio Durigan Junior wrote: > On Saturday, August 26 2017, Joel Brobecker wrote: > >> Hello, >> >> On Fri, Aug 25, 2017 at 08:48:58PM -0400, gdb-buildbot@sergiodj.net wrote: >>> My lords, ladies, gentlemen, members of the public. >>> >>> It is a matter of great regret and sadness to inform you that commit: >>> >>> remove param "dispp" from ada-lang.c::ada_lookup_struct_elt_type >>> 988f6b3dc615173d6d78a76ac26c109b4582da74 >>> >>> might have made GDB unwell. Since I am just your Butler BuildBot, >>> I kindly ask that a human superior officer double-check this. >> >> My change only touches a static function in ada-lang.c, while >> the error is reported inside sparc64-tdep. Maybe an earlier commit? > > Yeah, sorry about these messages. BuildBot is currently not smart > enough to figure out that the failure was not introduced by the last > commit. One solution, proposed by Pedro, is to send the breakage e-mail > to the authors of all commits that haven't been tested until the last > one, but that's also not easy to do... I'll investigate and see if > there's any other way. > You can keep track of errors for the current commit and do not send an email if the next commit doesn't change errors. -- H.J.