From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124808 invoked by alias); 26 Aug 2017 19:54:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 124798 invoked by uid 89); 26 Aug 2017 19:54:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=HX-Greylist:Sat, officer, dear, kindly X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 26 Aug 2017 19:54:00 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9777BC04B936; Sat, 26 Aug 2017 19:53:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 9777BC04B936 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=sergiodj@redhat.com Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 70A8660BE1; Sat, 26 Aug 2017 19:53:59 +0000 (UTC) From: Sergio Durigan Junior To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: Oh dear. I regret to inform you that commit 'remove param "dispp" from ada-lang.c::ada_lookup_struct_elt_type' might be unfortunate References: <20170826123906.wg5s7qsm65lklk5s@adacore.com> Date: Sat, 26 Aug 2017 19:54:00 -0000 In-Reply-To: <20170826123906.wg5s7qsm65lklk5s@adacore.com> (Joel Brobecker's message of "Sat, 26 Aug 2017 08:39:06 -0400") Message-ID: <87mv6m9kbt.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-08/txt/msg00499.txt.bz2 On Saturday, August 26 2017, Joel Brobecker wrote: > Hello, > > On Fri, Aug 25, 2017 at 08:48:58PM -0400, gdb-buildbot@sergiodj.net wrote: >> My lords, ladies, gentlemen, members of the public. >> >> It is a matter of great regret and sadness to inform you that commit: >> >> remove param "dispp" from ada-lang.c::ada_lookup_struct_elt_type >> 988f6b3dc615173d6d78a76ac26c109b4582da74 >> >> might have made GDB unwell. Since I am just your Butler BuildBot, >> I kindly ask that a human superior officer double-check this. > > My change only touches a static function in ada-lang.c, while > the error is reported inside sparc64-tdep. Maybe an earlier commit? Yeah, sorry about these messages. BuildBot is currently not smart enough to figure out that the failure was not introduced by the last commit. One solution, proposed by Pedro, is to send the breakage e-mail to the authors of all commits that haven't been tested until the last one, but that's also not easy to do... I'll investigate and see if there's any other way. Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/