Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Siva Chandra <sivachandra@google.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC - Python Scripting] New method gdb.Architecture.disassemble
Date: Thu, 07 Feb 2013 14:14:00 -0000	[thread overview]
Message-ID: <CAGyQ6gzP6AqNhBG0rj04gMraL6UB_P_-+namwUL8n_APLO2j+g@mail.gmail.com> (raw)
In-Reply-To: <87y5f1w6xc.fsf@fleche.redhat.com>

On Wed, Feb 6, 2013 at 11:58 AM, Tom Tromey <tromey@redhat.com> wrote:
> Why is it a method on gdb.Architecture and not elsewhere?
> For example, we have gdb.Inferior.read_memory.

Based on a comment in this thread,
http://sourceware.org/ml/gdb-patches/2012-11/msg00052.html, I gather
that architecture could change between frames. Hence, would it not be
more appropriate to have this method on gdb.Architecture?

> Siva> +struct ui_out *py_out;
>
> I'd rather avoid new globals, and I don't see what this one adds.

The only reason I made it global is because there is no way currently
to free up a ui_out object from outside of ui-out.c. Do you think it
is OK to add a field ui_out_destroy_ftype to struct ui_out_impl? If
yes, then I think we can first add the support for this 'virtual
destructor' in a separate patch.

Thanks,
Siva Chandra


  parent reply	other threads:[~2013-02-07 14:14 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-04 14:09 Siva Chandra
2013-02-05 23:28 ` Doug Evans
2013-02-06  1:53   ` Siva Chandra
2013-02-06 20:00     ` Tom Tromey
2013-02-08 18:05     ` Doug Evans
2013-02-09 17:55       ` Matt Rice
2013-02-12 14:56       ` Siva Chandra
2013-02-12 21:18         ` Tom Tromey
2013-02-13 14:37           ` Siva Chandra
2013-02-13 17:52             ` Eli Zaretskii
2013-02-13 18:03             ` Tom Tromey
2013-02-13 19:50               ` Siva Chandra
2013-02-13 20:42                 ` Doug Evans
2013-02-14 22:46                   ` Siva Chandra
2013-02-15  6:43                     ` Doug Evans
2013-02-15 17:32                       ` Doug Evans
2013-02-15 17:40                         ` Siva Chandra
2013-02-15 17:41                           ` Siva Chandra
2013-02-15 18:57                           ` Doug Evans
2013-02-15 20:36                       ` Siva Chandra
2013-02-15 21:01                         ` Siva Chandra
2013-02-16  5:30                           ` Doug Evans
2013-02-16  8:47                           ` Eli Zaretskii
2013-02-19  5:36                             ` Siva Chandra
2013-02-19 15:51                               ` Paul_Koning
2013-02-19 16:35                                 ` Eli Zaretskii
2013-02-19 16:38                               ` Eli Zaretskii
2013-02-20 12:34                                 ` Siva Chandra
2013-02-20 18:44                                   ` Eli Zaretskii
2013-02-21  1:49                                     ` Siva Chandra
2013-02-06 19:58 ` Tom Tromey
2013-02-06 20:31   ` Phil Muldoon
2013-02-06 22:31   ` Matt Rice
2013-02-06 23:19     ` Siva Chandra
2013-02-07  1:11       ` Siva Chandra
2013-02-07 23:03         ` Matt Rice
     [not found]       ` <20130206235707.GA2353@klara.mpi.htwm.de>
2013-02-07  1:18         ` Siva Chandra
2013-02-07 14:14   ` Siva Chandra [this message]
2013-02-07 16:42     ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGyQ6gzP6AqNhBG0rj04gMraL6UB_P_-+namwUL8n_APLO2j+g@mail.gmail.com \
    --to=sivachandra@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox