From: Doug Evans <dje@google.com>
To: Siva Chandra <sivachandra@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>,
Tom Tromey <tromey@redhat.com>, Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFC - Python Scripting] New method gdb.Architecture.disassemble
Date: Fri, 15 Feb 2013 17:32:00 -0000 [thread overview]
Message-ID: <CADPb22Txs4KJ8oQmCTmFpjoUFOBsannfCnr6ZxY3OWLH7GXxDg@mail.gmail.com> (raw)
In-Reply-To: <20765.55532.700460.792597@ruffy2.mtv.corp.google.com>
On Thu, Feb 14, 2013 at 10:42 PM, Doug Evans <dje@google.com> wrote:
> Hi.
> Thanks for persevering!
> Just nits at this point.
>
> Siva Chandra writes:
> > I now have a patch (find it attached) which has been tweaked based on
> > comments from Doug.
> >
> > Thanks Doug, for another round of detailed feedback.
> >
> > 2013-02-13 Siva Chandra Reddy <sivachandra@google.com>
> >
> > Add a new method 'disassemble' to gdb.Architecture class.
> > * python/py-arch.c (archpy_disassmble): Implementation of the
> > new method gdb.Architecture.disassemble.
> > (arch_object_methods): Add entry for the new method.
> >
> > doc/
> >
> > * gdb.texinfo (Architectures In Python): Add description about
> > the new method gdb.Architecture.disassemble.
> >
> > testsuite/
> >
> > * gdb.python/py-arch.c: New test case
> > * gdb.python/py-arch.exp: New tests to test
> > gdb.Architecture.disassemble
> > * gdb.python/Makefile.in: Add py-arch to the list of
> > EXECUTABLES.
Oh, duh. Sorry for the followup.
This needs a NEWS entry.
next prev parent reply other threads:[~2013-02-15 17:32 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-04 14:09 Siva Chandra
2013-02-05 23:28 ` Doug Evans
2013-02-06 1:53 ` Siva Chandra
2013-02-06 20:00 ` Tom Tromey
2013-02-08 18:05 ` Doug Evans
2013-02-09 17:55 ` Matt Rice
2013-02-12 14:56 ` Siva Chandra
2013-02-12 21:18 ` Tom Tromey
2013-02-13 14:37 ` Siva Chandra
2013-02-13 17:52 ` Eli Zaretskii
2013-02-13 18:03 ` Tom Tromey
2013-02-13 19:50 ` Siva Chandra
2013-02-13 20:42 ` Doug Evans
2013-02-14 22:46 ` Siva Chandra
2013-02-15 6:43 ` Doug Evans
2013-02-15 17:32 ` Doug Evans [this message]
2013-02-15 17:40 ` Siva Chandra
2013-02-15 17:41 ` Siva Chandra
2013-02-15 18:57 ` Doug Evans
2013-02-15 20:36 ` Siva Chandra
2013-02-15 21:01 ` Siva Chandra
2013-02-16 5:30 ` Doug Evans
2013-02-16 8:47 ` Eli Zaretskii
2013-02-19 5:36 ` Siva Chandra
2013-02-19 15:51 ` Paul_Koning
2013-02-19 16:35 ` Eli Zaretskii
2013-02-19 16:38 ` Eli Zaretskii
2013-02-20 12:34 ` Siva Chandra
2013-02-20 18:44 ` Eli Zaretskii
2013-02-21 1:49 ` Siva Chandra
2013-02-06 19:58 ` Tom Tromey
2013-02-06 20:31 ` Phil Muldoon
2013-02-06 22:31 ` Matt Rice
2013-02-06 23:19 ` Siva Chandra
2013-02-07 1:11 ` Siva Chandra
2013-02-07 23:03 ` Matt Rice
[not found] ` <20130206235707.GA2353@klara.mpi.htwm.de>
2013-02-07 1:18 ` Siva Chandra
2013-02-07 14:14 ` Siva Chandra
2013-02-07 16:42 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADPb22Txs4KJ8oQmCTmFpjoUFOBsannfCnr6ZxY3OWLH7GXxDg@mail.gmail.com \
--to=dje@google.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=sivachandra@google.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox