Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Matt Rice <ratmice@gmail.com>
To: Doug Evans <dje@google.com>
Cc: Siva Chandra <sivachandra@google.com>,
	gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [RFC - Python Scripting] New method gdb.Architecture.disassemble
Date: Sat, 09 Feb 2013 17:55:00 -0000	[thread overview]
Message-ID: <CACTLOFpBWbLAwc6g2TujwgjfwdovsNZfp+7gmVh4sUpBRLv+yg@mail.gmail.com> (raw)
In-Reply-To: <CADPb22TGJNFg7VJkeoTB7Ctd=K2Tc490LKo_mdUVXFF2K6TV5g@mail.gmail.com>

On Fri, Feb 8, 2013 at 10:05 AM, Doug Evans <dje@google.com> wrote:

> Let's take a step back and assume one wants to add disassembly to Python,
> without knowing anything about what gdb does and doesn't already provide.

Thanks for bringing this up, all very good points.

> Global State In An API Is Bad.

definitely agree, part of why i was wondering if the ui-out object
shouldn't be passed in to the disassemble method was because it seemed
more pure

I suppose this leads me to consider that the "data-disassemble" command is
(untested though) exposed already via the 'mi_execute' functions in
the PR #11688
which already has generic conversion of arguments to and from mi commands.

to transcribe an example (untested) from the mi docs [1]
gdb.mi_execute("data-disassemble", ("-s", "$pc", "-e", "$pc+20", "--", 0))

This at least makes it rather apparent that we aren't working with a
real python API
and are using a python version of some gdb command interpreter (and
all that entails).
that at least gives us a stopgap that we can use while codifying a real API

does disassemble method vs generic mi method make any difference?
my main concern with the generic mi method is that it makes the coding
of any real
python API addressing your concerns somewhat less imminent

[1] http://sourceware.org/gdb/current/onlinedocs/gdb/GDB_002fMI-Data-Manipulation.html#GDB_002fMI-Data-Manipulation


  reply	other threads:[~2013-02-09 17:55 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-04 14:09 Siva Chandra
2013-02-05 23:28 ` Doug Evans
2013-02-06  1:53   ` Siva Chandra
2013-02-06 20:00     ` Tom Tromey
2013-02-08 18:05     ` Doug Evans
2013-02-09 17:55       ` Matt Rice [this message]
2013-02-12 14:56       ` Siva Chandra
2013-02-12 21:18         ` Tom Tromey
2013-02-13 14:37           ` Siva Chandra
2013-02-13 17:52             ` Eli Zaretskii
2013-02-13 18:03             ` Tom Tromey
2013-02-13 19:50               ` Siva Chandra
2013-02-13 20:42                 ` Doug Evans
2013-02-14 22:46                   ` Siva Chandra
2013-02-15  6:43                     ` Doug Evans
2013-02-15 17:32                       ` Doug Evans
2013-02-15 17:40                         ` Siva Chandra
2013-02-15 17:41                           ` Siva Chandra
2013-02-15 18:57                           ` Doug Evans
2013-02-15 20:36                       ` Siva Chandra
2013-02-15 21:01                         ` Siva Chandra
2013-02-16  5:30                           ` Doug Evans
2013-02-16  8:47                           ` Eli Zaretskii
2013-02-19  5:36                             ` Siva Chandra
2013-02-19 15:51                               ` Paul_Koning
2013-02-19 16:35                                 ` Eli Zaretskii
2013-02-19 16:38                               ` Eli Zaretskii
2013-02-20 12:34                                 ` Siva Chandra
2013-02-20 18:44                                   ` Eli Zaretskii
2013-02-21  1:49                                     ` Siva Chandra
2013-02-06 19:58 ` Tom Tromey
2013-02-06 20:31   ` Phil Muldoon
2013-02-06 22:31   ` Matt Rice
2013-02-06 23:19     ` Siva Chandra
2013-02-07  1:11       ` Siva Chandra
2013-02-07 23:03         ` Matt Rice
     [not found]       ` <20130206235707.GA2353@klara.mpi.htwm.de>
2013-02-07  1:18         ` Siva Chandra
2013-02-07 14:14   ` Siva Chandra
2013-02-07 16:42     ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACTLOFpBWbLAwc6g2TujwgjfwdovsNZfp+7gmVh4sUpBRLv+yg@mail.gmail.com \
    --to=ratmice@gmail.com \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=sivachandra@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox