From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9374 invoked by alias); 15 Feb 2013 17:32:13 -0000 Received: (qmail 9359 invoked by uid 22791); 15 Feb 2013 17:32:07 -0000 X-SWARE-Spam-Status: No, hits=-5.6 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-vb0-f53.google.com (HELO mail-vb0-f53.google.com) (209.85.212.53) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 15 Feb 2013 17:32:01 +0000 Received: by mail-vb0-f53.google.com with SMTP id fj18so2249949vbb.26 for ; Fri, 15 Feb 2013 09:32:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:x-gm-message-state; bh=mPTE2NRJebFgG6nqLSyK4bwe7hpZMdQWjCRQNZBzcSI=; b=TNFA1Bou2WBefXtQ1pV87JHXnb//E/WkX4HY/XAULEhl38WKTZV7hZx/XB8ELTVZWE dc1uoRv/VSMAHAMD7tLOKITq0FHbOm86f5BqU9aBREJ8bhtVMmYB7ksI9uytfN6p826P jwucFmco6MQYG22DBTtD0LFQyzZxRb4aSar4ovuobbP8tScbvOTDCugIvGv8rhoBosaD dRhqNbKHtAPosjhAUGCpHktGRYmuv7U+NSCv4XBEE4+kfGyWsJpB3UQke41srIOu1OxF vStqsHhSiTtbR4f4/hhBxdNwSiz4CJcfpHg+ucNrPxV3mhAIgCwryydd7bH2SaNzCDBA ootA== MIME-Version: 1.0 X-Received: by 10.52.21.175 with SMTP id w15mr3690684vde.100.1360949520436; Fri, 15 Feb 2013 09:32:00 -0800 (PST) Received: by 10.220.210.69 with HTTP; Fri, 15 Feb 2013 09:32:00 -0800 (PST) In-Reply-To: <20765.55532.700460.792597@ruffy2.mtv.corp.google.com> References: <20753.38272.55066.651097@ruffy2.mtv.corp.google.com> <87txphmdt3.fsf@fleche.redhat.com> <87r4kkks5g.fsf@fleche.redhat.com> <20763.64197.459891.627211@ruffy2.mtv.corp.google.com> <20765.55532.700460.792597@ruffy2.mtv.corp.google.com> Date: Fri, 15 Feb 2013 17:32:00 -0000 Message-ID: Subject: Re: [RFC - Python Scripting] New method gdb.Architecture.disassemble From: Doug Evans To: Siva Chandra Cc: gdb-patches , Tom Tromey , Eli Zaretskii Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQlmGhYKT/n22WRXSotDvTwXCozZCiLw+D51girpoZClJ1qAf8bwpRc7oP081KCN1X6rCpwWgDPeonSQokOY7wsIPSdgMwK3HZTSJ6jaG2gOHrG1hO6DPCS0kIZ4wmRFggy8yTPT8FzcjUUXAAjChRdu0pngAwmOa0HcK9joIeCqIeUHLXHlFAa5woLwRYSB/HZNlR5du1+f1zGDpxvPUVH/K3+xVA== X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00398.txt.bz2 On Thu, Feb 14, 2013 at 10:42 PM, Doug Evans wrote: > Hi. > Thanks for persevering! > Just nits at this point. > > Siva Chandra writes: > > I now have a patch (find it attached) which has been tweaked based on > > comments from Doug. > > > > Thanks Doug, for another round of detailed feedback. > > > > 2013-02-13 Siva Chandra Reddy > > > > Add a new method 'disassemble' to gdb.Architecture class. > > * python/py-arch.c (archpy_disassmble): Implementation of the > > new method gdb.Architecture.disassemble. > > (arch_object_methods): Add entry for the new method. > > > > doc/ > > > > * gdb.texinfo (Architectures In Python): Add description about > > the new method gdb.Architecture.disassemble. > > > > testsuite/ > > > > * gdb.python/py-arch.c: New test case > > * gdb.python/py-arch.exp: New tests to test > > gdb.Architecture.disassemble > > * gdb.python/Makefile.in: Add py-arch to the list of > > EXECUTABLES. Oh, duh. Sorry for the followup. This needs a NEWS entry.