From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12882 invoked by alias); 7 Feb 2013 14:14:26 -0000 Received: (qmail 12853 invoked by uid 22791); 7 Feb 2013 14:14:24 -0000 X-SWARE-Spam-Status: No, hits=-5.5 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-ea0-f180.google.com (HELO mail-ea0-f180.google.com) (209.85.215.180) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 07 Feb 2013 14:14:18 +0000 Received: by mail-ea0-f180.google.com with SMTP id c1so1093216eaa.11 for ; Thu, 07 Feb 2013 06:14:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:x-gm-message-state; bh=tziUolVsikr0PR1QVJ5TY3Z1h/P5AE3WXcEigXeCR3E=; b=Ve6wAfNWvlJPlljCGngs6QKKTPYAUvKArMwcQzIK4k85yTu0QxAdxJbS+pX3fNBKzB LVu6XjCJwxd42dX0uJRPSgf8R9yUi8O9DXVB3hDR4XQGsEUOPtXWwv2wnYmrlcdg6K06 i58KvbOc2iOOTl8WTzf6AXFs4OOsyoXyRvhOfTBpOowbyMFIjfTbzWmm0qw01PKcNVuA EYXDQAhjSzvB516RpNwsd29fN345QC48HjLhnlTOBe9SMoHzSmTYo1p2wiLBFGSvmFqJ oeTIe1+YH1gl9+x41QtcvaWPKibRmqI8CFXqQA9b6gnZGGA0gE2lYQtY7rxFD2ECifAK aEWA== MIME-Version: 1.0 X-Received: by 10.14.199.135 with SMTP id x7mr4527463een.18.1360246457369; Thu, 07 Feb 2013 06:14:17 -0800 (PST) Received: by 10.14.100.200 with HTTP; Thu, 7 Feb 2013 06:14:17 -0800 (PST) In-Reply-To: <87y5f1w6xc.fsf@fleche.redhat.com> References: <87y5f1w6xc.fsf@fleche.redhat.com> Date: Thu, 07 Feb 2013 14:14:00 -0000 Message-ID: Subject: Re: [RFC - Python Scripting] New method gdb.Architecture.disassemble From: Siva Chandra To: Tom Tromey Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQmcu4jFcCmBjjvmGFT8CMP5OYDjsa5QGSQS4bzDuPir3A1gJAsbIC4q3m3HbE6FkX5840UXV5HPrWsF++ARfbSxjTnqCwko3deGC6UmnGjh0Nt52P0tvyMaMCqCQ79BVVjlR5syJzYg8JZbqtYRNOC+jrnAtabuezHhMz9L06ChY1Ix+QL96Bix2DnWAQw+eOMg0OAJ1SJ65GUMQYHRfGBajYu6nw== X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00177.txt.bz2 On Wed, Feb 6, 2013 at 11:58 AM, Tom Tromey wrote: > Why is it a method on gdb.Architecture and not elsewhere? > For example, we have gdb.Inferior.read_memory. Based on a comment in this thread, http://sourceware.org/ml/gdb-patches/2012-11/msg00052.html, I gather that architecture could change between frames. Hence, would it not be more appropriate to have this method on gdb.Architecture? > Siva> +struct ui_out *py_out; > > I'd rather avoid new globals, and I don't see what this one adds. The only reason I made it global is because there is no way currently to free up a ui_out object from outside of ui-out.c. Do you think it is OK to add a field ui_out_destroy_ftype to struct ui_out_impl? If yes, then I think we can first add the support for this 'virtual destructor' in a separate patch. Thanks, Siva Chandra