From: Doug Evans <dje@google.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: Joel Brobecker <brobecker@adacore.com>,
gdb-patches@sourceware.org,
Andrey Smirnov <andrew.smirnov@gmail.com>,
Marek Polacek <mpolacek@redhat.com>
Subject: Re: [PATCH 22/348] Fix -Wsahdow warnings
Date: Wed, 23 Nov 2011 17:25:00 -0000 [thread overview]
Message-ID: <CADPb22SVNNVCGRG9UgJNW7J19pMboMUPORbHWL6AmJ6ruU9Q7A@mail.gmail.com> (raw)
In-Reply-To: <201111221120.06244.vapier@gentoo.org>
On Tue, Nov 22, 2011 at 8:20 AM, Mike Frysinger <vapier@gentoo.org> wrote:
>> > your ChangeLogs are also incorrect. it should not be:
>> > * bcache.c (expand_hash_table): Fix -Wshadow warnings.
>> >
>> > but rather:
>> > * bcache.c (expand_hash_table): Rename bcache to cache.
>>
>> I'm 50/50 on this. I don't mind either way. What do others think?
>> Is that really that important that we must create boring extra work
>> for Andrey?
>
> it's my understanding that the GNU changelog style is "document what changed"
> and not "why". i think that's largely stupid, but i'm not the one in control
> of said policy.
For little things like this, at least for those that are internal to a function,
I've seen a lot of leeway and I think that's ok.
fwiw.
next prev parent reply other threads:[~2011-11-23 17:25 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 13:07 Andrey Smirnov
2011-11-22 13:14 ` Eli Zaretskii
2011-11-22 13:34 ` Andrey Smirnov
2011-11-22 13:35 ` Marek Polacek
2011-11-22 14:04 ` Andrey Smirnov
2011-11-22 15:28 ` Mike Frysinger
2011-11-22 16:05 ` Joel Brobecker
2011-11-22 16:20 ` Mike Frysinger
2011-11-23 17:25 ` Doug Evans [this message]
2011-11-22 18:24 ` Tom Tromey
2011-11-23 16:46 ` Mark Kettenis
[not found] ` <CAHQ1cqFADK_pXv4JAW6ouvm_NPyM6dM+-FmVF0FojKi1rs98Wg@mail.gmail.com>
2011-11-24 3:23 ` Andrey Smirnov
2011-11-23 5:29 ` Andrey Smirnov
2011-11-23 17:06 ` Tom Tromey
2011-11-24 3:18 ` Andrey Smirnov
2011-11-23 17:56 ` Doug Evans
2011-11-23 18:03 ` Doug Evans
2011-11-23 20:16 ` Joel Brobecker
2011-11-24 4:33 ` Andrey Smirnov
2011-11-29 19:06 ` Tom Tromey
2011-11-28 15:07 ` [PATCH 022/238] [misc.] bcache.c: -Wshadow fix Andrey Smirnov
2011-11-28 15:07 ` [PATCH 025/238] " Andrey Smirnov
2011-12-20 15:42 ` Tom Tromey
2011-11-28 15:07 ` [PATCH 026/238] " Andrey Smirnov
2011-12-20 15:43 ` Tom Tromey
2011-11-28 15:07 ` [PATCH 024/238] " Andrey Smirnov
2011-12-20 15:46 ` Tom Tromey
2011-12-20 15:42 ` [PATCH 022/238] " Tom Tromey
2011-12-20 16:13 ` Andrey Smirnov
2011-12-20 19:17 ` Tom Tromey
2011-12-20 19:31 ` Andrey Smirnov
2011-12-20 21:06 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADPb22SVNNVCGRG9UgJNW7J19pMboMUPORbHWL6AmJ6ruU9Q7A@mail.gmail.com \
--to=dje@google.com \
--cc=andrew.smirnov@gmail.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=mpolacek@redhat.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox