From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-85451-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 20499 invoked by alias); 23 Nov 2011 17:25:27 -0000
Received: (qmail 20487 invoked by uid 22791); 23 Nov 2011 17:25:26 -0000
X-SWARE-Spam-Status: No, hits=-3.9 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mail-qw0-f48.google.com (HELO mail-qw0-f48.google.com) (209.85.216.48)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 23 Nov 2011 17:25:13 +0000
Received: by qady1 with SMTP id y1so510591qad.0        for <gdb-patches@sourceware.org>; Wed, 23 Nov 2011 09:25:12 -0800 (PST)
Received: by 10.224.17.148 with SMTP id s20mr11343722qaa.55.1322069112374;        Wed, 23 Nov 2011 09:25:12 -0800 (PST)
MIME-Version: 1.0
Received: by 10.224.17.148 with SMTP id s20mr11343698qaa.55.1322069112154; Wed, 23 Nov 2011 09:25:12 -0800 (PST)
Received: by 10.224.6.76 with HTTP; Wed, 23 Nov 2011 09:25:12 -0800 (PST)
In-Reply-To: <201111221120.06244.vapier@gentoo.org>
References: <878vn88fw3.fsf@gmail.com>	<201111221027.52484.vapier@gentoo.org>	<20111122160539.GA22283@adacore.com>	<201111221120.06244.vapier@gentoo.org>
Date: Wed, 23 Nov 2011 17:25:00 -0000
Message-ID: <CADPb22SVNNVCGRG9UgJNW7J19pMboMUPORbHWL6AmJ6ruU9Q7A@mail.gmail.com>
Subject: Re: [PATCH 22/348] Fix -Wsahdow warnings
From: Doug Evans <dje@google.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: Joel Brobecker <brobecker@adacore.com>, gdb-patches@sourceware.org, 	Andrey Smirnov <andrew.smirnov@gmail.com>, Marek Polacek <mpolacek@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-System-Of-Record: true
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-11/txt/msg00628.txt.bz2

On Tue, Nov 22, 2011 at 8:20 AM, Mike Frysinger <vapier@gentoo.org> wrote:
>> > your ChangeLogs are also incorrect. =A0it should not be:
>> > =A0 =A0 * bcache.c (expand_hash_table): Fix -Wshadow warnings.
>> >
>> > but rather:
>> > =A0 =A0 * bcache.c (expand_hash_table): Rename bcache to cache.
>>
>> I'm 50/50 on this. I don't mind either way. What do others think?
>> Is that really that important that we must create boring extra work
>> for Andrey?
>
> it's my understanding that the GNU changelog style is "document what chan=
ged"
> and not "why". =A0i think that's largely stupid, but i'm not the one in c=
ontrol
> of said policy.

For little things like this, at least for those that are internal to a func=
tion,
I've seen a lot of leeway and I think that's ok.
fwiw.