Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 024/238] [misc.] bcache.c: -Wshadow fix
Date: Mon, 28 Nov 2011 15:07:00 -0000	[thread overview]
Message-ID: <1322492788-29388-2-git-send-email-andrew.smirnov@gmail.com> (raw)
In-Reply-To: <1322492788-29388-1-git-send-email-andrew.smirnov@gmail.com>

Cause:
        `bcache' function from "bcache.h"

To ChangeLog:
	* bcache.c (bcache_full): Rename `bcache' to `cache'(-Wshadow).
---
 gdb/ChangeLog |    5 +++++
 gdb/bcache.c  |   36 ++++++++++++++++++------------------
 2 files changed, 23 insertions(+), 18 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 431e4f6..f23767c 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
 2011-11-22  Andrey Smirnov <andrew.smirnov@gmail.com>
 
+	* bcache.c (bcache_full): Fix -Wshadow
+	warnings.
+
+2011-11-22  Andrey Smirnov <andrew.smirnov@gmail.com>
+
 	* bcache.c (bcache): Fix -Wshadow
 	warnings.
 
diff --git a/gdb/bcache.c b/gdb/bcache.c
index 035ed22..6e51cf2 100644
--- a/gdb/bcache.c
+++ b/gdb/bcache.c
@@ -221,7 +221,7 @@ bcache (const void *addr, int length, struct bcache *cache)
    returning an old entry.  */
 
 const void *
-bcache_full (const void *addr, int length, struct bcache *bcache, int *added)
+bcache_full (const void *addr, int length, struct bcache *cache, int *added)
 {
   unsigned long full_hash;
   unsigned short half_hash;
@@ -233,55 +233,55 @@ bcache_full (const void *addr, int length, struct bcache *bcache, int *added)
 
   /* Lazily initialize the obstack.  This can save quite a bit of
      memory in some cases.  */
-  if (bcache->total_count == 0)
+  if (cache->total_count == 0)
     {
       /* We could use obstack_specify_allocation here instead, but
 	 gdb_obstack.h specifies the allocation/deallocation
 	 functions.  */
-      obstack_init (&bcache->cache);
+      obstack_init (&cache->cache);
     }
 
   /* If our average chain length is too high, expand the hash table.  */
-  if (bcache->unique_count >= bcache->num_buckets * CHAIN_LENGTH_THRESHOLD)
-    expand_hash_table (bcache);
+  if (cache->unique_count >= cache->num_buckets * CHAIN_LENGTH_THRESHOLD)
+    expand_hash_table (cache);
 
-  bcache->total_count++;
-  bcache->total_size += length;
+  cache->total_count++;
+  cache->total_size += length;
 
-  full_hash = bcache->hash_function (addr, length);
+  full_hash = cache->hash_function (addr, length);
 
   half_hash = (full_hash >> 16);
-  hash_index = full_hash % bcache->num_buckets;
+  hash_index = full_hash % cache->num_buckets;
 
   /* Search the hash bucket for a string identical to the caller's.
      As a short-circuit first compare the upper part of each hash
      values.  */
-  for (s = bcache->bucket[hash_index]; s; s = s->next)
+  for (s = cache->bucket[hash_index]; s; s = s->next)
     {
       if (s->half_hash == half_hash)
 	{
 	  if (s->length == length
-	      && bcache->compare_function (&s->d.data, addr, length))
+	      && cache->compare_function (&s->d.data, addr, length))
 	    return &s->d.data;
 	  else
-	    bcache->half_hash_miss_count++;
+	    cache->half_hash_miss_count++;
 	}
     }
 
   /* The user's string isn't in the list.  Insert it after *ps.  */
   {
     struct bstring *new
-      = obstack_alloc (&bcache->cache, BSTRING_SIZE (length));
+      = obstack_alloc (&cache->cache, BSTRING_SIZE (length));
 
     memcpy (&new->d.data, addr, length);
     new->length = length;
-    new->next = bcache->bucket[hash_index];
+    new->next = cache->bucket[hash_index];
     new->half_hash = half_hash;
-    bcache->bucket[hash_index] = new;
+    cache->bucket[hash_index] = new;
 
-    bcache->unique_count++;
-    bcache->unique_size += length;
-    bcache->structure_size += BSTRING_SIZE (length);
+    cache->unique_count++;
+    cache->unique_size += length;
+    cache->structure_size += BSTRING_SIZE (length);
 
     if (added)
       *added = 1;
-- 
1.7.5.4


  reply	other threads:[~2011-11-28 15:07 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-22 13:07 [PATCH 22/348] Fix -Wsahdow warnings Andrey Smirnov
2011-11-22 13:14 ` Eli Zaretskii
2011-11-22 13:34   ` Andrey Smirnov
2011-11-22 13:35     ` Marek Polacek
2011-11-22 14:04       ` Andrey Smirnov
2011-11-22 15:28         ` Mike Frysinger
2011-11-22 16:05           ` Joel Brobecker
2011-11-22 16:20             ` Mike Frysinger
2011-11-23 17:25               ` Doug Evans
2011-11-22 18:24             ` Tom Tromey
2011-11-23 16:46             ` Mark Kettenis
     [not found]               ` <CAHQ1cqFADK_pXv4JAW6ouvm_NPyM6dM+-FmVF0FojKi1rs98Wg@mail.gmail.com>
2011-11-24  3:23                 ` Andrey Smirnov
2011-11-23  5:29           ` Andrey Smirnov
2011-11-23 17:06             ` Tom Tromey
2011-11-24  3:18               ` Andrey Smirnov
2011-11-23 17:56             ` Doug Evans
2011-11-23 18:03               ` Doug Evans
2011-11-23 20:16                 ` Joel Brobecker
2011-11-24  4:33               ` Andrey Smirnov
2011-11-29 19:06                 ` Tom Tromey
2011-11-28 15:07         ` [PATCH 022/238] [misc.] bcache.c: -Wshadow fix Andrey Smirnov
2011-11-28 15:07           ` Andrey Smirnov [this message]
2011-12-20 15:46             ` [PATCH 024/238] " Tom Tromey
2011-11-28 15:07           ` [PATCH 026/238] " Andrey Smirnov
2011-12-20 15:43             ` Tom Tromey
2011-11-28 15:07           ` [PATCH 025/238] " Andrey Smirnov
2011-12-20 15:42             ` Tom Tromey
2011-12-20 15:42           ` [PATCH 022/238] " Tom Tromey
2011-12-20 16:13             ` Andrey Smirnov
2011-12-20 19:17               ` Tom Tromey
2011-12-20 19:31                 ` Andrey Smirnov
2011-12-20 21:06                   ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1322492788-29388-2-git-send-email-andrew.smirnov@gmail.com \
    --to=andrew.smirnov@gmail.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox