From: Tom Tromey <tromey@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Mike Frysinger <vapier@gentoo.org>,
gdb-patches@sourceware.org,
Andrey Smirnov <andrew.smirnov@gmail.com>,
Marek Polacek <mpolacek@redhat.com>
Subject: Re: [PATCH 22/348] Fix -Wsahdow warnings
Date: Tue, 22 Nov 2011 18:24:00 -0000 [thread overview]
Message-ID: <m362ic3tjf.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20111122160539.GA22283@adacore.com> (Joel Brobecker's message of "Tue, 22 Nov 2011 08:05:39 -0800")
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
>> please condense down your patches if you resend. there's way too many
>> little tiny ones that really should be squashed into a single
>> changeset.
Joel> In my view, if the patches can be checked in independently, then
Joel> it is a good thing that they are split. Imagine the situation where
Joel> one of these changes is bad, we'd then be able to revert that one
Joel> patch, rather than fixing by hand.
I think a bit more batching would be ok.
It doesn't really matter to me, though, I will go through them all
either way.
>> your ChangeLogs are also incorrect. it should not be:
>> * bcache.c (expand_hash_table): Fix -Wshadow warnings.
>> but rather:
>> * bcache.c (expand_hash_table): Rename bcache to cache.
Joel> I'm 50/50 on this. I don't mind either way. What do others think?
Joel> Is that really that important that we must create boring extra work
Joel> for Andrey?
I can't imagine rewriting 348 ChangeLog entries.
Tom
next prev parent reply other threads:[~2011-11-22 18:24 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 13:07 Andrey Smirnov
2011-11-22 13:14 ` Eli Zaretskii
2011-11-22 13:34 ` Andrey Smirnov
2011-11-22 13:35 ` Marek Polacek
2011-11-22 14:04 ` Andrey Smirnov
2011-11-22 15:28 ` Mike Frysinger
2011-11-22 16:05 ` Joel Brobecker
2011-11-22 16:20 ` Mike Frysinger
2011-11-23 17:25 ` Doug Evans
2011-11-22 18:24 ` Tom Tromey [this message]
2011-11-23 16:46 ` Mark Kettenis
[not found] ` <CAHQ1cqFADK_pXv4JAW6ouvm_NPyM6dM+-FmVF0FojKi1rs98Wg@mail.gmail.com>
2011-11-24 3:23 ` Andrey Smirnov
2011-11-23 5:29 ` Andrey Smirnov
2011-11-23 17:06 ` Tom Tromey
2011-11-24 3:18 ` Andrey Smirnov
2011-11-23 17:56 ` Doug Evans
2011-11-23 18:03 ` Doug Evans
2011-11-23 20:16 ` Joel Brobecker
2011-11-24 4:33 ` Andrey Smirnov
2011-11-29 19:06 ` Tom Tromey
2011-11-28 15:07 ` [PATCH 022/238] [misc.] bcache.c: -Wshadow fix Andrey Smirnov
2011-11-28 15:07 ` [PATCH 025/238] " Andrey Smirnov
2011-12-20 15:42 ` Tom Tromey
2011-11-28 15:07 ` [PATCH 026/238] " Andrey Smirnov
2011-12-20 15:43 ` Tom Tromey
2011-11-28 15:07 ` [PATCH 024/238] " Andrey Smirnov
2011-12-20 15:46 ` Tom Tromey
2011-12-20 15:42 ` [PATCH 022/238] " Tom Tromey
2011-12-20 16:13 ` Andrey Smirnov
2011-12-20 19:17 ` Tom Tromey
2011-12-20 19:31 ` Andrey Smirnov
2011-12-20 21:06 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m362ic3tjf.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=andrew.smirnov@gmail.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=mpolacek@redhat.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox