From: Mike Frysinger <vapier@gentoo.org>
To: gdb-patches@sourceware.org
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>,
Marek Polacek <mpolacek@redhat.com>
Subject: Re: [PATCH 22/348] Fix -Wsahdow warnings
Date: Tue, 22 Nov 2011 15:28:00 -0000 [thread overview]
Message-ID: <201111221027.52484.vapier@gentoo.org> (raw)
In-Reply-To: <CAHQ1cqHNswA2d5dDQsiu3i0kGe6rDFs+izUNYoWcvcf4NaLd0Q@mail.gmail.com>
[-- Attachment #1: Type: Text/Plain, Size: 957 bytes --]
On Tuesday 22 November 2011 09:04:07 Andrey Smirnov wrote:
> On Tue, Nov 22, 2011 at 8:35 PM, Marek Polacek <mpolacek@redhat.com> wrote:
> > On 11/22/2011 02:33 PM, Andrey Smirnov wrote:
> >>> Is the typo intentional?
> >>
> >> Sorry about that. No it isn't. Please ignore that particular patch I'll
> >> send corrected version soon(I'm in the middle of a git rebase
> >> --interactive, so I can't edit that particular commit just yet).
> >
> > That typo is in other patches too.
>
> OK, once again, sorry about that, I'll recheck all the patches related
> to bcache.c, for now please ignore those.
please condense down your patches if you resend. there's way too many little
tiny ones that really should be squashed into a single changeset.
your ChangeLogs are also incorrect. it should not be:
* bcache.c (expand_hash_table): Fix -Wshadow warnings.
but rather:
* bcache.c (expand_hash_table): Rename bcache to cache.
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2011-11-22 15:28 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 13:07 Andrey Smirnov
2011-11-22 13:14 ` Eli Zaretskii
2011-11-22 13:34 ` Andrey Smirnov
2011-11-22 13:35 ` Marek Polacek
2011-11-22 14:04 ` Andrey Smirnov
2011-11-22 15:28 ` Mike Frysinger [this message]
2011-11-22 16:05 ` Joel Brobecker
2011-11-22 16:20 ` Mike Frysinger
2011-11-23 17:25 ` Doug Evans
2011-11-22 18:24 ` Tom Tromey
2011-11-23 16:46 ` Mark Kettenis
[not found] ` <CAHQ1cqFADK_pXv4JAW6ouvm_NPyM6dM+-FmVF0FojKi1rs98Wg@mail.gmail.com>
2011-11-24 3:23 ` Andrey Smirnov
2011-11-23 5:29 ` Andrey Smirnov
2011-11-23 17:06 ` Tom Tromey
2011-11-24 3:18 ` Andrey Smirnov
2011-11-23 17:56 ` Doug Evans
2011-11-23 18:03 ` Doug Evans
2011-11-23 20:16 ` Joel Brobecker
2011-11-24 4:33 ` Andrey Smirnov
2011-11-29 19:06 ` Tom Tromey
2011-11-28 15:07 ` [PATCH 022/238] [misc.] bcache.c: -Wshadow fix Andrey Smirnov
2011-11-28 15:07 ` [PATCH 025/238] " Andrey Smirnov
2011-12-20 15:42 ` Tom Tromey
2011-11-28 15:07 ` [PATCH 026/238] " Andrey Smirnov
2011-12-20 15:43 ` Tom Tromey
2011-11-28 15:07 ` [PATCH 024/238] " Andrey Smirnov
2011-12-20 15:46 ` Tom Tromey
2011-12-20 15:42 ` [PATCH 022/238] " Tom Tromey
2011-12-20 16:13 ` Andrey Smirnov
2011-12-20 19:17 ` Tom Tromey
2011-12-20 19:31 ` Andrey Smirnov
2011-12-20 21:06 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111221027.52484.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=andrew.smirnov@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=mpolacek@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox