From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3795 invoked by alias); 22 Nov 2011 15:28:07 -0000 Received: (qmail 3777 invoked by uid 22791); 22 Nov 2011 15:28:05 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 22 Nov 2011 15:27:49 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 44550641F7; Tue, 22 Nov 2011 15:27:49 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: Re: [PATCH 22/348] Fix -Wsahdow warnings Date: Tue, 22 Nov 2011 15:28:00 -0000 User-Agent: KMail/1.13.7 (Linux/3.1.1; KDE/4.6.5; x86_64; ; ) Cc: Andrey Smirnov , Marek Polacek References: <878vn88fw3.fsf@gmail.com> <4ECBA525.1010801@redhat.com> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2405095.zgBuNFtJrx"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201111221027.52484.vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00582.txt.bz2 --nextPart2405095.zgBuNFtJrx Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-length: 947 On Tuesday 22 November 2011 09:04:07 Andrey Smirnov wrote: > On Tue, Nov 22, 2011 at 8:35 PM, Marek Polacek wrot= e: > > On 11/22/2011 02:33 PM, Andrey Smirnov wrote: > >>> Is the typo intentional? > >>=20 > >> Sorry about that. No it isn't. Please ignore that particular patch I'll > >> send corrected version soon(I'm in the middle of a git rebase > >> --interactive, so I can't edit that particular commit just yet). > >=20 > > That typo is in other patches too. >=20 > OK, once again, sorry about that, I'll recheck all the patches related > to bcache.c, for now please ignore those. please condense down your patches if you resend. there's way too many litt= le=20 tiny ones that really should be squashed into a single changeset. your ChangeLogs are also incorrect. it should not be: * bcache.c (expand_hash_table): Fix -Wshadow warnings. but rather: * bcache.c (expand_hash_table): Rename bcache to cache. -mike --nextPart2405095.zgBuNFtJrx Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJOy794AAoJEEFjO5/oN/WBZX8P/3eLJOeKhZ9qarqWT5yInjnY 1eM7ylN8/oPCqbE5i0vCbpUHDhwnIZduWOZ5dBOVHvNSXgoWW+7qICHiwCSBh8sZ eF9Ze6GDA8tFFGAmPD3aMsp7Ku9YstzEId6liwwVEbDkl/S0uT13N9wM8DIY8ueZ 5jg9viYd21Yeh09OB6tZhT14MiHGDxbcKe1RQWgzcaMM+CJ/R1S9jbunQC3jTf1t Zp8YftdQdQfh4BgeDsDrplRj94fD13LliEXd0cQ0W/nifmXrYp0VbaZw4xMcIBtF Fxf2RgH8xhAeGga1j+LDWxbuOkk37kmoyCv3+JwM4TDHf7tkv7LRphuUHOTHpR9i abaa/BfaizFULNMO9tsP/Fa5l3UFtJi+z6NeZ2FC0d8RTn2ZtXiFg4D09jFgVcTd dD29ELmDSBeHEDqHZAPGQMvLGPoDtSdC9LyCcq2idl6iVEW9EE3SxZWqk2q1CrmJ YJfyZ6S91P/eLnlirCsuw/1tE8q1ktaZ3LrMcJUNGdhr7+X+RWuhRhpM3TiS+f9a DJEwJlGvQg7ygWe4BNyS09/WfVaaxBa8y/DaaKzUk+vrn1i7dYEXi7DCmMPpvDPD KYuFvePhoWdM8Fkx3pfHegkMDEHuWdPQWsw9IYDeU4ZCk6Ynqtr2pDiGqBLMmtIj L+37uTAS4eHbGcz5RQJP =f1eq -----END PGP SIGNATURE----- --nextPart2405095.zgBuNFtJrx--