* [RFA] bfd, elf32-i386.c (elf_i386_relocate_section): Document fall through.
@ 2011-03-06 0:57 Michael Snyder
2011-03-06 1:37 ` H.J. Lu
0 siblings, 1 reply; 3+ messages in thread
From: Michael Snyder @ 2011-03-06 0:57 UTC (permalink / raw)
To: gdb-patches, binutils, H.J. Lu
[-- Attachment #1: Type: text/plain, Size: 98 bytes --]
There could be a break statement missing here.
If not, then it is good to comment the fact.
OK?
[-- Attachment #2: elf32-i386.txt --]
[-- Type: text/plain, Size: 638 bytes --]
2011-03-05 Michael Snyder <msnyder@vmware.com>
* elf32-i386.c (elf_i386_relocate_section): Document fall through.
Index: elf32-i386.c
===================================================================
RCS file: /cvs/src/src/bfd/elf32-i386.c,v
retrieving revision 1.242
diff -u -p -r1.242 elf32-i386.c
--- elf32-i386.c 6 Jan 2011 18:45:05 -0000 1.242
+++ elf32-i386.c 6 Mar 2011 00:53:50 -0000
@@ -3128,7 +3128,7 @@ elf_i386_relocate_section (bfd *output_b
internal symbol, we have updated addend. */
continue;
}
-
+ /* FALLTHROUGH */
case R_386_PC32:
case R_386_PLT32:
goto do_relocation;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA] bfd, elf32-i386.c (elf_i386_relocate_section): Document fall through.
2011-03-06 0:57 [RFA] bfd, elf32-i386.c (elf_i386_relocate_section): Document fall through Michael Snyder
@ 2011-03-06 1:37 ` H.J. Lu
2011-03-06 18:37 ` Michael Snyder
0 siblings, 1 reply; 3+ messages in thread
From: H.J. Lu @ 2011-03-06 1:37 UTC (permalink / raw)
To: Michael Snyder; +Cc: gdb-patches, binutils
On Sat, Mar 5, 2011 at 4:57 PM, Michael Snyder <msnyder@vmware.com> wrote:
> There could be a break statement missing here.
> If not, then it is good to comment the fact.
>
> OK?
>
>
> 2011-03-05 Michael Snyder <msnyder@vmware.com>
>
> * elf32-i386.c (elf_i386_relocate_section): Document fall through.
>
> Index: elf32-i386.c
> ===================================================================
> RCS file: /cvs/src/src/bfd/elf32-i386.c,v
> retrieving revision 1.242
> diff -u -p -r1.242 elf32-i386.c
> --- elf32-i386.c 6 Jan 2011 18:45:05 -0000 1.242
> +++ elf32-i386.c 6 Mar 2011 00:53:50 -0000
> @@ -3128,7 +3128,7 @@ elf_i386_relocate_section (bfd *output_b
> internal symbol, we have updated addend. */
> continue;
> }
> -
> + /* FALLTHROUGH */
> case R_386_PC32:
> case R_386_PLT32:
> goto do_relocation;
>
>
OK. Thanks.
--
H.J.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA] bfd, elf32-i386.c (elf_i386_relocate_section): Document fall through.
2011-03-06 1:37 ` H.J. Lu
@ 2011-03-06 18:37 ` Michael Snyder
0 siblings, 0 replies; 3+ messages in thread
From: Michael Snyder @ 2011-03-06 18:37 UTC (permalink / raw)
To: H.J. Lu; +Cc: gdb-patches, binutils
H.J. Lu wrote:
> On Sat, Mar 5, 2011 at 4:57 PM, Michael Snyder <msnyder@vmware.com> wrote:
>> There could be a break statement missing here.
>> If not, then it is good to comment the fact.
>>
>> OK?
>>
>>
>> 2011-03-05 Michael Snyder <msnyder@vmware.com>
>>
>> * elf32-i386.c (elf_i386_relocate_section): Document fall through.
>>
>> Index: elf32-i386.c
>> ===================================================================
>> RCS file: /cvs/src/src/bfd/elf32-i386.c,v
>> retrieving revision 1.242
>> diff -u -p -r1.242 elf32-i386.c
>> --- elf32-i386.c 6 Jan 2011 18:45:05 -0000 1.242
>> +++ elf32-i386.c 6 Mar 2011 00:53:50 -0000
>> @@ -3128,7 +3128,7 @@ elf_i386_relocate_section (bfd *output_b
>> internal symbol, we have updated addend. */
>> continue;
>> }
>> -
>> + /* FALLTHROUGH */
>> case R_386_PC32:
>> case R_386_PLT32:
>> goto do_relocation;
>>
>>
>
> OK. Thanks.
Committed, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-03-06 18:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-03-06 0:57 [RFA] bfd, elf32-i386.c (elf_i386_relocate_section): Document fall through Michael Snyder
2011-03-06 1:37 ` H.J. Lu
2011-03-06 18:37 ` Michael Snyder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox