From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-79269-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 6619 invoked by alias); 6 Mar 2011 01:37:37 -0000
Received: (qmail 6605 invoked by uid 22791); 6 Mar 2011 01:37:36 -0000
X-SWARE-Spam-Status: No, hits=-2.3 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW
X-Spam-Check-By: sourceware.org
Received: from mail-iy0-f169.google.com (HELO mail-iy0-f169.google.com) (209.85.210.169)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 06 Mar 2011 01:37:30 +0000
Received: by iyf13 with SMTP id 13so4056002iyf.0        for <multiple recipients>; Sat, 05 Mar 2011 17:37:29 -0800 (PST)
MIME-Version: 1.0
Received: by 10.43.53.208 with SMTP id vr16mr744397icb.245.1299375449238; Sat, 05 Mar 2011 17:37:29 -0800 (PST)
Received: by 10.42.60.129 with HTTP; Sat, 5 Mar 2011 17:37:29 -0800 (PST)
In-Reply-To: <4D72DBF4.9080401@vmware.com>
References: <4D72DBF4.9080401@vmware.com>
Date: Sun, 06 Mar 2011 01:37:00 -0000
Message-ID: <AANLkTikq6aewsrmPx0A3yRB3_4DY7Yr1ptjYM8dJfOg_@mail.gmail.com>
Subject: Re: [RFA] bfd, elf32-i386.c (elf_i386_relocate_section): Document fall through.
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Michael Snyder <msnyder@vmware.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>, binutils@sourceware.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-03/txt/msg00382.txt.bz2

On Sat, Mar 5, 2011 at 4:57 PM, Michael Snyder <msnyder@vmware.com> wrote:
> There could be a break statement missing here.
> If not, then it is good to comment the fact.
>
> OK?
>
>
> 2011-03-05 =A0Michael Snyder =A0<msnyder@vmware.com>
>
> =A0 =A0 =A0 =A0* elf32-i386.c (elf_i386_relocate_section): Document fall =
through.
>
> Index: elf32-i386.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> RCS file: /cvs/src/src/bfd/elf32-i386.c,v
> retrieving revision 1.242
> diff -u -p -r1.242 elf32-i386.c
> --- elf32-i386.c =A0 =A0 =A0 =A06 Jan 2011 18:45:05 -0000 =A0 =A0 =A0 1.2=
42
> +++ elf32-i386.c =A0 =A0 =A0 =A06 Mar 2011 00:53:50 -0000
> @@ -3128,7 +3128,7 @@ elf_i386_relocate_section (bfd *output_b
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 internal symbol, we have updated =
addend. =A0*/
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0continue;
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0}
> -
> + =A0 =A0 =A0 =A0 =A0 =A0 /* FALLTHROUGH */
> =A0 =A0 =A0 =A0 =A0 =A0case R_386_PC32:
> =A0 =A0 =A0 =A0 =A0 =A0case R_386_PLT32:
> =A0 =A0 =A0 =A0 =A0 =A0 =A0goto do_relocation;
>
>

OK.  Thanks.

--=20
H.J.