From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-79286-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 24457 invoked by alias); 6 Mar 2011 18:23:15 -0000
Received: (qmail 24444 invoked by uid 22791); 6 Mar 2011 18:23:15 -0000
X-SWARE-Spam-Status: No, hits=-5.2 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 06 Mar 2011 18:23:09 +0000
Received: from mailhost3.vmware.com (mailhost3.vmware.com [10.16.27.45])	by smtp-outbound-1.vmware.com (Postfix) with ESMTP id 5EDA213417;	Sun,  6 Mar 2011 10:23:06 -0800 (PST)
Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138])	by mailhost3.vmware.com (Postfix) with ESMTP id 54127CD9AD;	Sun,  6 Mar 2011 10:23:06 -0800 (PST)
Message-ID: <4D73D109.6000301@vmware.com>
Date: Sun, 06 Mar 2011 18:37:00 -0000
From: Michael Snyder <msnyder@vmware.com>
User-Agent: Thunderbird 2.0.0.24 (X11/20101201)
MIME-Version: 1.0
To: "H.J. Lu" <hjl.tools@gmail.com>
CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,  "binutils@sourceware.org" <binutils@sourceware.org>
Subject: Re: [RFA] bfd, elf32-i386.c (elf_i386_relocate_section): Document fall through.
References: <4D72DBF4.9080401@vmware.com> <AANLkTikq6aewsrmPx0A3yRB3_4DY7Yr1ptjYM8dJfOg_@mail.gmail.com>
In-Reply-To: <AANLkTikq6aewsrmPx0A3yRB3_4DY7Yr1ptjYM8dJfOg_@mail.gmail.com>
Content-Type: text/plain; charset=iso-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-03/txt/msg00399.txt.bz2

H.J. Lu wrote:
> On Sat, Mar 5, 2011 at 4:57 PM, Michael Snyder <msnyder@vmware.com> wrote:
>> There could be a break statement missing here.
>> If not, then it is good to comment the fact.
>>
>> OK?
>>
>>
>> 2011-03-05  Michael Snyder  <msnyder@vmware.com>
>>
>>        * elf32-i386.c (elf_i386_relocate_section): Document fall through.
>>
>> Index: elf32-i386.c
>> ===================================================================
>> RCS file: /cvs/src/src/bfd/elf32-i386.c,v
>> retrieving revision 1.242
>> diff -u -p -r1.242 elf32-i386.c
>> --- elf32-i386.c        6 Jan 2011 18:45:05 -0000       1.242
>> +++ elf32-i386.c        6 Mar 2011 00:53:50 -0000
>> @@ -3128,7 +3128,7 @@ elf_i386_relocate_section (bfd *output_b
>>                     internal symbol, we have updated addend.  */
>>                  continue;
>>                }
>> -
>> +             /* FALLTHROUGH */
>>            case R_386_PC32:
>>            case R_386_PLT32:
>>              goto do_relocation;
>>
>>
> 
> OK.  Thanks.

Committed, thanks.