From: Michael Snyder <msnyder@vmware.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
binutils@sourceware.org, "H.J. Lu" <hjl.tools@gmail.com>
Subject: [RFA] bfd, elf32-i386.c (elf_i386_relocate_section): Document fall through.
Date: Sun, 06 Mar 2011 00:57:00 -0000 [thread overview]
Message-ID: <4D72DBF4.9080401@vmware.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 98 bytes --]
There could be a break statement missing here.
If not, then it is good to comment the fact.
OK?
[-- Attachment #2: elf32-i386.txt --]
[-- Type: text/plain, Size: 638 bytes --]
2011-03-05 Michael Snyder <msnyder@vmware.com>
* elf32-i386.c (elf_i386_relocate_section): Document fall through.
Index: elf32-i386.c
===================================================================
RCS file: /cvs/src/src/bfd/elf32-i386.c,v
retrieving revision 1.242
diff -u -p -r1.242 elf32-i386.c
--- elf32-i386.c 6 Jan 2011 18:45:05 -0000 1.242
+++ elf32-i386.c 6 Mar 2011 00:53:50 -0000
@@ -3128,7 +3128,7 @@ elf_i386_relocate_section (bfd *output_b
internal symbol, we have updated addend. */
continue;
}
-
+ /* FALLTHROUGH */
case R_386_PC32:
case R_386_PLT32:
goto do_relocation;
next reply other threads:[~2011-03-06 0:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-06 0:57 Michael Snyder [this message]
2011-03-06 1:37 ` H.J. Lu
2011-03-06 18:37 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D72DBF4.9080401@vmware.com \
--to=msnyder@vmware.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox