From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17625 invoked by alias); 6 Mar 2011 00:57:33 -0000 Received: (qmail 17608 invoked by uid 22791); 6 Mar 2011 00:57:32 -0000 X-SWARE-Spam-Status: No, hits=-5.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 06 Mar 2011 00:57:26 +0000 Received: from mailhost2.vmware.com (mailhost2.vmware.com [10.16.67.167]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id E28422A01C; Sat, 5 Mar 2011 16:57:24 -0800 (PST) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost2.vmware.com (Postfix) with ESMTP id 92F298EC3C; Sat, 5 Mar 2011 16:57:24 -0800 (PST) Message-ID: <4D72DBF4.9080401@vmware.com> Date: Sun, 06 Mar 2011 00:57:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.24 (X11/20101201) MIME-Version: 1.0 To: "gdb-patches@sourceware.org" , binutils@sourceware.org, "H.J. Lu" Subject: [RFA] bfd, elf32-i386.c (elf_i386_relocate_section): Document fall through. Content-Type: multipart/mixed; boundary="------------070200030205070507010700" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00379.txt.bz2 This is a multi-part message in MIME format. --------------070200030205070507010700 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 98 There could be a break statement missing here. If not, then it is good to comment the fact. OK? --------------070200030205070507010700 Content-Type: text/plain; name="elf32-i386.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="elf32-i386.txt" Content-length: 638 2011-03-05 Michael Snyder * elf32-i386.c (elf_i386_relocate_section): Document fall through. Index: elf32-i386.c =================================================================== RCS file: /cvs/src/src/bfd/elf32-i386.c,v retrieving revision 1.242 diff -u -p -r1.242 elf32-i386.c --- elf32-i386.c 6 Jan 2011 18:45:05 -0000 1.242 +++ elf32-i386.c 6 Mar 2011 00:53:50 -0000 @@ -3128,7 +3128,7 @@ elf_i386_relocate_section (bfd *output_b internal symbol, we have updated addend. */ continue; } - + /* FALLTHROUGH */ case R_386_PC32: case R_386_PLT32: goto do_relocation; --------------070200030205070507010700--