From: Simon Marchi <simon.marchi@polymtl.ca>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/4] Fix detach.exp remote check
Date: Mon, 02 May 2016 17:11:00 -0000 [thread overview]
Message-ID: <9fea935b6df94385daa28ba851ecd7f4@simark.ca> (raw)
In-Reply-To: <570BEA08.2070806@redhat.com>
On 2016-04-11 14:16, Pedro Alves wrote:
> On 04/06/2016 04:15 AM, Simon Marchi wrote:
>> This test seems to work with both native-gdbserver and
>> native-extended-gdbserver, so I removed the remote check.
>>
>> When running with native-gdbserver (a stub-like target), detach makes
>> gdbserver stop and gdb disconnect. runto_main just spawns a brand new
>> gdbserver. So it tests the exact same thing twice. It doesn't hurt
>> though.
>
> It's not exactly the same thing, as the second test runs with the same
> gdb, so it exercises "run" or "target connect" after a previous
> "detach", which can expose problems with stale state from the previous
> connection. So also useful.
True.
>> gdb/testsuite/ChangeLog:
>>
>> * gdb.base/detach.exp: Remove is_remote check.
>
> OK.
I pushed this one as well, thanks.
next prev parent reply other threads:[~2016-05-02 17:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-06 3:15 [PATCH 1/4] native-gdbserver: Clear isremote flag in board info Simon Marchi
2016-04-06 3:15 ` [PATCH 3/4] Fix detach.exp remote check Simon Marchi
2016-04-11 18:16 ` Pedro Alves
2016-05-02 17:11 ` Simon Marchi [this message]
2016-04-06 3:15 ` [PATCH 2/4] Fix annota-input-while-running.exp " Simon Marchi
2016-04-11 18:03 ` Pedro Alves
2016-05-02 17:07 ` Simon Marchi
2016-04-06 3:15 ` [PATCH 4/4] Fix solib-display.exp " Simon Marchi
2016-04-11 18:27 ` Pedro Alves
2016-04-11 19:26 ` Simon Marchi
2016-04-11 21:32 ` Pedro Alves
2016-04-11 21:38 ` Pedro Alves
2016-05-02 18:20 ` Simon Marchi
2016-05-02 18:28 ` Pedro Alves
2016-05-02 19:52 ` Simon Marchi
2016-05-03 23:19 ` Pedro Alves
2016-04-11 18:40 ` [PATCH 1/4] native-gdbserver: Clear isremote flag in board info Pedro Alves
2016-04-11 19:14 ` Simon Marchi
2016-04-11 21:29 ` Pedro Alves
2016-04-11 23:14 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fea935b6df94385daa28ba851ecd7f4@simark.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox