Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/4] Fix annota-input-while-running.exp remote check
Date: Mon, 11 Apr 2016 18:03:00 -0000	[thread overview]
Message-ID: <570BE706.3090804@redhat.com> (raw)
In-Reply-To: <1459912543-15328-2-git-send-email-simon.marchi@polymtl.ca>

On 04/06/2016 04:15 AM, Simon Marchi wrote:
> The comment says that we can't use runto_main here becore it doesn't
> know how to handle annotation.  Instead, the test puts a breakpoint at
> main and calls run by hand.  Therefore, it can't work with stub targets,
> since they can't "run".  The check should be then changed to check the
> use_gdb_stub variable instead of [is_remote target].
> 
> But as an alternative, we can just use runto_main and enable annotations
> after, since the "run to main" part is not really part of what we want
> to test.
> 
> I also removed the "set test..." line that is unused.
> 

I probably copied this from one of the other annotation tests, like
annota1.exp.  Some of those do want to do annotation tests
before "run" though.

> gdb/testsuite/ChangeLog:
> 
> 	* gdb.base/annota-input-while-running.exp: Don't check for
> 	[is_remote target].  Enable annotations after running to main.
> 	Remove unused "set test..." line.

OK.

Thanks,
Pedro Alves


  reply	other threads:[~2016-04-11 18:03 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-06  3:15 [PATCH 1/4] native-gdbserver: Clear isremote flag in board info Simon Marchi
2016-04-06  3:15 ` [PATCH 4/4] Fix solib-display.exp remote check Simon Marchi
2016-04-11 18:27   ` Pedro Alves
2016-04-11 19:26     ` Simon Marchi
2016-04-11 21:32       ` Pedro Alves
2016-04-11 21:38         ` Pedro Alves
2016-05-02 18:20     ` Simon Marchi
2016-05-02 18:28       ` Pedro Alves
2016-05-02 19:52         ` Simon Marchi
2016-05-03 23:19           ` Pedro Alves
2016-04-06  3:15 ` [PATCH 3/4] Fix detach.exp " Simon Marchi
2016-04-11 18:16   ` Pedro Alves
2016-05-02 17:11     ` Simon Marchi
2016-04-06  3:15 ` [PATCH 2/4] Fix annota-input-while-running.exp " Simon Marchi
2016-04-11 18:03   ` Pedro Alves [this message]
2016-05-02 17:07     ` Simon Marchi
2016-04-11 18:40 ` [PATCH 1/4] native-gdbserver: Clear isremote flag in board info Pedro Alves
2016-04-11 19:14   ` Simon Marchi
2016-04-11 21:29     ` Pedro Alves
2016-04-11 23:14       ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=570BE706.3090804@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox