From: Simon Marchi <simon.marchi@polymtl.ca>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 4/4] Fix solib-display.exp remote check
Date: Mon, 11 Apr 2016 19:26:00 -0000 [thread overview]
Message-ID: <dcd2914b07d0118e12d3e0082f9f691b@simark.ca> (raw)
In-Reply-To: <570BECA8.3050801@redhat.com>
On 2016-04-11 14:27, Pedro Alves wrote:
> On 04/06/2016 04:15 AM, Simon Marchi wrote:
>
>> The test uses "run"
>
> Does it have to? Can't we use "kill" followed by runto_main
> again, instead of gdb_start_cmd ?
I'll check.
> Why did you move the check to within the loop? I thought one
> could check [target_info exists use_gdb_stub] at the top?
> I'd find the patch OK with that. It'd be nicer to avoid
> gdb_start_cmd in the first place, but use_gdb_stub is still
> an improvement.
You're right, I didn't think to check [target_info exists use_gdb_stub]
directly. The global variable use_gdb_stub is only available after
having spawned gdb, which is why I moved it.
next prev parent reply other threads:[~2016-04-11 19:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-06 3:15 [PATCH 1/4] native-gdbserver: Clear isremote flag in board info Simon Marchi
2016-04-06 3:15 ` [PATCH 3/4] Fix detach.exp remote check Simon Marchi
2016-04-11 18:16 ` Pedro Alves
2016-05-02 17:11 ` Simon Marchi
2016-04-06 3:15 ` [PATCH 2/4] Fix annota-input-while-running.exp " Simon Marchi
2016-04-11 18:03 ` Pedro Alves
2016-05-02 17:07 ` Simon Marchi
2016-04-06 3:15 ` [PATCH 4/4] Fix solib-display.exp " Simon Marchi
2016-04-11 18:27 ` Pedro Alves
2016-04-11 19:26 ` Simon Marchi [this message]
2016-04-11 21:32 ` Pedro Alves
2016-04-11 21:38 ` Pedro Alves
2016-05-02 18:20 ` Simon Marchi
2016-05-02 18:28 ` Pedro Alves
2016-05-02 19:52 ` Simon Marchi
2016-05-03 23:19 ` Pedro Alves
2016-04-11 18:40 ` [PATCH 1/4] native-gdbserver: Clear isremote flag in board info Pedro Alves
2016-04-11 19:14 ` Simon Marchi
2016-04-11 21:29 ` Pedro Alves
2016-04-11 23:14 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dcd2914b07d0118e12d3e0082f9f691b@simark.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox