Re: [PATCH 4/4] Fix solib-display.exp remote check

[Pedro Alves <palves@redhat.com>]

On 05/02/2016 08:52 PM, Simon Marchi wrote:
> On 2016-05-02 14:28, Pedro Alves wrote:
>> Thanks for the investigation.  I think it'd be nice to
>> add this info as a comment in the test file.
>>
>> Thanks,
>> Pedro Alves
> 
> What about:
> 
> # This test is currently not supported for stub targets, because it uses
> the
> # start command (through gdb_start_cmd).  In theory, it could be changed to
> # use something else (kill + gdb_run_cmd with a manual breakpoint at main).
> # However, when we try that with the native-gdbserver board, we see that
> the
> # test fails and gdb outputs this upon connection:
> #
> #   warning: Unable to display "a_global": No symbol "a_global" in
> current context.
> #   warning: Unable to display "b_global": No symbol "b_global" in
> current context.
> #   warning: Unable to display "c_global": No symbol "c_global" in
> current context.
> #
> # This is because the initial stop is done before the shared libraries are
> # loaded.  If there were some stub targets for which this use case would be
> # supported, then the test could probably be modified to avoid using start.

LGTM, though I'd drop the last sentence.  One could argue that this
_should_ work, and that gdb could re-enable the displays when
the shared libraries are loaded, akin to shared library breakpoints.

Thanks,
Pedro Alves