Re: [PATCH 2/4] Fix annota-input-while-running.exp remote check

[Simon Marchi <simon.marchi@polymtl.ca>]

On 2016-04-11 14:03, Pedro Alves wrote:
> On 04/06/2016 04:15 AM, Simon Marchi wrote:
>> The comment says that we can't use runto_main here becore it doesn't
>> know how to handle annotation.  Instead, the test puts a breakpoint at
>> main and calls run by hand.  Therefore, it can't work with stub 
>> targets,
>> since they can't "run".  The check should be then changed to check the
>> use_gdb_stub variable instead of [is_remote target].
>> 
>> But as an alternative, we can just use runto_main and enable 
>> annotations
>> after, since the "run to main" part is not really part of what we want
>> to test.
>> 
>> I also removed the "set test..." line that is unused.
>> 
> 
> I probably copied this from one of the other annotation tests, like
> annota1.exp.  Some of those do want to do annotation tests
> before "run" though.

Right.

>> gdb/testsuite/ChangeLog:
>> 
>> 	* gdb.base/annota-input-while-running.exp: Don't check for
>> 	[is_remote target].  Enable annotations after running to main.
>> 	Remove unused "set test..." line.
> 
> OK.

I have pushed this one, since it's valid itself.

Thanks.