From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 84499 invoked by alias); 11 Apr 2016 18:03:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 84487 invoked by uid 89); 11 Apr 2016 18:03:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 11 Apr 2016 18:03:53 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3D4B31B0A; Mon, 11 Apr 2016 18:03:52 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u3BI3otY007578; Mon, 11 Apr 2016 14:03:51 -0400 Subject: Re: [PATCH 2/4] Fix annota-input-while-running.exp remote check To: Simon Marchi , gdb-patches@sourceware.org References: <1459912543-15328-1-git-send-email-simon.marchi@polymtl.ca> <1459912543-15328-2-git-send-email-simon.marchi@polymtl.ca> From: Pedro Alves Message-ID: <570BE706.3090804@redhat.com> Date: Mon, 11 Apr 2016 18:03:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <1459912543-15328-2-git-send-email-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-04/txt/msg00216.txt.bz2 On 04/06/2016 04:15 AM, Simon Marchi wrote: > The comment says that we can't use runto_main here becore it doesn't > know how to handle annotation. Instead, the test puts a breakpoint at > main and calls run by hand. Therefore, it can't work with stub targets, > since they can't "run". The check should be then changed to check the > use_gdb_stub variable instead of [is_remote target]. > > But as an alternative, we can just use runto_main and enable annotations > after, since the "run to main" part is not really part of what we want > to test. > > I also removed the "set test..." line that is unused. > I probably copied this from one of the other annotation tests, like annota1.exp. Some of those do want to do annotation tests before "run" though. > gdb/testsuite/ChangeLog: > > * gdb.base/annota-input-while-running.exp: Don't check for > [is_remote target]. Enable annotations after running to main. > Remove unused "set test..." line. OK. Thanks, Pedro Alves