From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 66476 invoked by alias); 2 May 2016 17:11:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 66451 invoked by uid 89); 2 May 2016 17:11:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=exercises, H*r:112, Hx-languages-length:857, brand X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 02 May 2016 17:11:11 +0000 Received: by simark.ca (Postfix, from userid 112) id 03C251E864; Mon, 2 May 2016 13:11:10 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 1DFD61E82D; Mon, 2 May 2016 13:11:09 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 02 May 2016 17:11:00 -0000 From: Simon Marchi To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/4] Fix detach.exp remote check In-Reply-To: <570BEA08.2070806@redhat.com> References: <1459912543-15328-1-git-send-email-simon.marchi@polymtl.ca> <1459912543-15328-3-git-send-email-simon.marchi@polymtl.ca> <570BEA08.2070806@redhat.com> Message-ID: <9fea935b6df94385daa28ba851ecd7f4@simark.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.1.3 X-SW-Source: 2016-05/txt/msg00015.txt.bz2 On 2016-04-11 14:16, Pedro Alves wrote: > On 04/06/2016 04:15 AM, Simon Marchi wrote: >> This test seems to work with both native-gdbserver and >> native-extended-gdbserver, so I removed the remote check. >> >> When running with native-gdbserver (a stub-like target), detach makes >> gdbserver stop and gdb disconnect. runto_main just spawns a brand new >> gdbserver. So it tests the exact same thing twice. It doesn't hurt >> though. > > It's not exactly the same thing, as the second test runs with the same > gdb, so it exercises "run" or "target connect" after a previous > "detach", which can expose problems with stale state from the previous > connection. So also useful. True. >> gdb/testsuite/ChangeLog: >> >> * gdb.base/detach.exp: Remove is_remote check. > > OK. I pushed this one as well, thanks.