Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simark@simark.ca>
To: Daniel Fellows <daniel.fellows@arm.com>
Cc: simon.marchi@efficios.com, gdb-patches@sourceware.org,
	tom@tromey.com, nd@arm.com
Subject: Re: [PATCH v2] gdb: use gdb::unordered_{set,map} at a few places
Date: Thu, 13 Aug 2026 09:04:07 -0400	[thread overview]
Message-ID: <89ceb9e7-3a23-4e2e-a94a-30a9d7303591@simark.ca> (raw)
In-Reply-To: <20260727162116.1042742-1-daniel.fellows@arm.com>

On 7/27/26 12:21 PM, Daniel Fellows wrote:
> Hi Simon,
> 
> Would you be willing to backport the solib-svr4.c change from this patch
> to gdb-17-branch?
> 
> We encountered the following build failure on both Intel and Arm macOS
> hosts after moving to GDB 17:
> 
> gdb/solib-svr4.c:3769:3: error:
> no template named 'unordered_map' in namespace 'std';
> did you mean 'gdb::unordered_map'?
> 
> I tested changing this instance to gdb::unordered_map, and it fixes the
> affected macOS builds.
> 
> The complete commit touches several unrelated files, has conflicts with
> gdb-17-branch, and part of it was later reverted for x86-nat.c. Only the
> solib-svr4.c change appears to be required here.
> 
> Would you be able to prepare that backport, or advise whether another
> approach would be preferred?
> 
> Thanks,
> Daniel

Hi Daniel,

Please note that there won't be any more releases from the
gdb-17-branch, but we can still push commits if that helps downstream
packagers like you.

For the stable branch, a more minimal fix could be to just include
<unordered_map> in the file.  Does that fix the build failure?

On another topic, does the gdb-18-branch look good to you?

Simon

  parent reply	other threads:[~2026-08-13 13:04 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-13 21:35 [PATCH] " Simon Marchi
2025-11-13 21:43 ` [PATCH v2] " Simon Marchi
2025-11-14 19:49   ` Tom Tromey
2025-11-14 20:00     ` Simon Marchi
2025-11-14 20:05       ` Tom Tromey
2025-11-14 20:32         ` Simon Marchi
2025-11-14 21:10           ` Tom Tromey
2025-11-14 21:15             ` Simon Marchi
2025-11-14 21:43               ` Tom Tromey
2025-11-14 22:20                 ` Simon Marchi
2025-11-17 15:58                   ` Tom Tromey
2025-11-17 16:31                     ` Simon Marchi
2026-07-27 16:21                       ` Daniel Fellows
2026-08-11 15:08                         ` Daniel Fellows
2026-08-13 13:04                         ` Simon Marchi [this message]
2026-08-14 12:06                           ` Daniel Fellows
2026-08-21 15:30                             ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=89ceb9e7-3a23-4e2e-a94a-30a9d7303591@simark.ca \
    --to=simark@simark.ca \
    --cc=daniel.fellows@arm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=nd@arm.com \
    --cc=simon.marchi@efficios.com \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox