Re: [PATCH v2] gdb: use gdb::unordered_{set,map} at a few places

[Tom Tromey <tom@tromey.com>]

>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

>> Adding DISABLE_COPY_AND_ASSIGN to proc_mem_file isn't really need, since
>> it's handled by scoped_fd, though maybe it's worthwhile for clarity.

Simon> I'm a bit confused with your answer.  But if I don't explicitly default
Simon> the move constructor and move assignment operator in proc_mem_file, it
Simon> won't build.  I would have expected proc_mem_file to automatically have
Simon> them since its scoped_fd field already is movable.  I don't understand
Simon> what makes it non-movable unless I explicitly default the operations.

The move operators are fine, this particular part of the note is just
saying that perhaps proc_mem_file would benefit from the explicit
addition of DISABLE_COPY_AND_ASSIGN.  However it's not truly needed.

Tom