From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id URfCHK6LF2muUwIAWB0awg (envelope-from ) for ; Fri, 14 Nov 2025 15:06:06 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=XkxKypIY; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 6E8851E0B8; Fri, 14 Nov 2025 15:06:06 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E3A151E04C for ; Fri, 14 Nov 2025 15:06:05 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8F4BC3858C20 for ; Fri, 14 Nov 2025 20:06:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8F4BC3858C20 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=XkxKypIY Received: from omta033.useast.a.cloudfilter.net (omta033.useast.a.cloudfilter.net [44.202.169.32]) by sourceware.org (Postfix) with ESMTPS id CA4A93858D21 for ; Fri, 14 Nov 2025 20:05:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CA4A93858D21 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CA4A93858D21 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.32 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1763150727; cv=none; b=CClRprZZPbe1gFuDLCxMCEFGH5F1zkh8npMG4hbtnQCjC6REJzNkHCZ8kb+0kAT/kBvhgYQP9C3VTqO0mi9zrMZJiFRaOuRmf5n9yFB9DARdOHChvpxugtBSOKGyWBYXzH/qGoQsU5dXMeV50xRdDPgcC8qMHKKQWkvziQUKenY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1763150727; c=relaxed/simple; bh=KuZOYhk9OFKfcFYphI64wgWmxyJCuMup05o164VpBy0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=kY6C+W+B8y3tL/hSv5yeYfiCMZJTdQk+I+RBxPPAoNJohsnyZtsOyAgHWi87Lx3JDgb/3Vto0jMgNt5lF2NdkOWq6EG8guT1/n3RbLzAA+je2G8yE2N1CYKMsGL29sxaAbr4EDOhycY1UYihXj5kfZjhr6LjnWw+Pw+bQl0wFHg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CA4A93858D21 Received: from eig-obgw-6002b.ext.cloudfilter.net ([10.0.30.203]) by cmsmtp with ESMTPS id Js83vOYijqgL9K02xvg3lF; Fri, 14 Nov 2025 20:05:27 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id K02vv2x0F74Z0K02wv2mag; Fri, 14 Nov 2025 20:05:26 +0000 X-Authority-Analysis: v=2.4 cv=BuidwZX5 c=1 sm=1 tr=0 ts=69178b86 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=6UeiqGixMTsA:10 a=ItBw4LHWJt0A:10 a=dzWzf_mpAAAA:8 a=SjHgGlbJO1gj60mDfs0A:9 a=b4DR9a7p2ZdsqdHBznES:22 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Ipd0m09Rbjdj3+Y4F5U/gnMS/vRAtm6nc2qRjr/a71g=; b=XkxKypIYIpv5HDD4V9UH/aby0j YESCYsMFe8TNEZBW/5KCsPD8vZyxFxQ61t/QtT/oMVlAzPjb21VawCoQx9ON/h06+AknnVwbzEA/e ZJZZldibXy8QTgpUfeFFfqW+o; Received: from 97-122-120-205.hlrn.qwest.net ([97.122.120.205]:60434 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vK02v-00000002sd0-2OCV; Fri, 14 Nov 2025 13:05:25 -0700 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH v2] gdb: use gdb::unordered_{set,map} at a few places In-Reply-To: (Simon Marchi's message of "Fri, 14 Nov 2025 15:00:59 -0500") References: <20251113213506.313040-1-simon.marchi@efficios.com> <20251113214507.359286-1-simon.marchi@efficios.com> <87a50ov1gv.fsf@tromey.com> X-Attribution: Tom Date: Fri, 14 Nov 2025 13:05:24 -0700 Message-ID: <87wm3stm63.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.120.205 X-Source-L: No X-Exim-ID: 1vK02v-00000002sd0-2OCV X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-120-205.hlrn.qwest.net (bapiya) [97.122.120.205]:60434 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfOjx5r3ASiA30F3hlEWKiNjxPQ6ljtJHhOnODdDm63BwauLeIM6LFMc9urYRoI9If5S77AK6ipgqjZAUnRFfTLnoDXx3CMMq95CaiyyTD6gHaPKxyA4r /9VdYwNtdRqB5xEMmdTAQ316pYAUlqI0EifyQjAb5eQDG7e8DAw1J/NDEx2DRamMN7Gqk3HglXijnUKWOnP/JEN9oDU68jJz4yc= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: >> Adding DISABLE_COPY_AND_ASSIGN to proc_mem_file isn't really need, since >> it's handled by scoped_fd, though maybe it's worthwhile for clarity. Simon> I'm a bit confused with your answer. But if I don't explicitly default Simon> the move constructor and move assignment operator in proc_mem_file, it Simon> won't build. I would have expected proc_mem_file to automatically have Simon> them since its scoped_fd field already is movable. I don't understand Simon> what makes it non-movable unless I explicitly default the operations. The move operators are fine, this particular part of the note is just saying that perhaps proc_mem_file would benefit from the explicit addition of DISABLE_COPY_AND_ASSIGN. However it's not truly needed. Tom