Re: [PATCH v2] gdb: use gdb::unordered_{set,map} at a few places

[Tom Tromey <tom@tromey.com>]

>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:

>> The move operators are fine, this particular part of the note is just
>> saying that perhaps proc_mem_file would benefit from the explicit
>> addition of DISABLE_COPY_AND_ASSIGN.  However it's not truly needed.

Simon> Ok, I have no problem being more explicit than necessary and using
Simon> DISABLE_COPY_AND_ASSIGN there.  See updated patch below.

Simon>    struct refcnt_fd
Simon>    {
Simon> -    DISABLE_COPY_AND_ASSIGN (refcnt_fd);
Simon>      refcnt_fd (int fd, int refcnt) : fd (fd), refcnt (refcnt) {}

I still think this removal is in error.  Is it really needed?
Allowing copying here would surely lead to bugs.

Tom