Re: [PATCH v2] gdb: use gdb::unordered_{set,map} at a few places

[Simon Marchi <simark@simark.ca>]

On 2025-11-14 16:10, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
> 
>>> The move operators are fine, this particular part of the note is just
>>> saying that perhaps proc_mem_file would benefit from the explicit
>>> addition of DISABLE_COPY_AND_ASSIGN.  However it's not truly needed.
> 
> Simon> Ok, I have no problem being more explicit than necessary and using
> Simon> DISABLE_COPY_AND_ASSIGN there.  See updated patch below.
> 
> Simon>    struct refcnt_fd
> Simon>    {
> Simon> -    DISABLE_COPY_AND_ASSIGN (refcnt_fd);
> Simon>      refcnt_fd (int fd, int refcnt) : fd (fd), refcnt (refcnt) {}
> 
> I still think this removal is in error.  Is it really needed?
> Allowing copying here would surely lead to bugs.

Well, since I defaulted the move operations, the copy operations are
disabled (at least that is my understanding).  But again, I can be more
explicit than needed, since it's clearer.

I think it's a bit odd to prevent copying this particular structure in
the first place, since it's not that structure that controls the release
of the resource, through its constructor.  It's done externally.

Simon