From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tom@tromey.com>,
Simon Marchi <simon.marchi@efficios.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH v2] gdb: use gdb::unordered_{set,map} at a few places
Date: Fri, 14 Nov 2025 14:43:00 -0700 [thread overview]
Message-ID: <87cy5kthnf.fsf@tromey.com> (raw)
In-Reply-To: <d8c4798e-ec8f-40d2-b3a4-c9a70bb84dac@simark.ca> (Simon Marchi's message of "Fri, 14 Nov 2025 16:15:26 -0500")
>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
Simon> I think it's a bit odd to prevent copying this particular structure in
Simon> the first place, since it's not that structure that controls the release
Simon> of the resource, through its constructor. It's done externally.
Yeah, I see now.
You can leave it as is I guess.
This type seems weird to me but on the other hand it's private to the
class that actually manages it.
Tom
next prev parent reply other threads:[~2025-11-14 21:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-13 21:35 [PATCH] " Simon Marchi
2025-11-13 21:43 ` [PATCH v2] " Simon Marchi
2025-11-14 19:49 ` Tom Tromey
2025-11-14 20:00 ` Simon Marchi
2025-11-14 20:05 ` Tom Tromey
2025-11-14 20:32 ` Simon Marchi
2025-11-14 21:10 ` Tom Tromey
2025-11-14 21:15 ` Simon Marchi
2025-11-14 21:43 ` Tom Tromey [this message]
2025-11-14 22:20 ` Simon Marchi
2025-11-17 15:58 ` Tom Tromey
2025-11-17 16:31 ` Simon Marchi
2026-07-27 16:21 ` Daniel Fellows
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cy5kthnf.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox