From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id HXBjA4GjF2khlgIAWB0awg (envelope-from ) for ; Fri, 14 Nov 2025 16:47:45 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=x2zifDl2; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id EEF771E04C; Fri, 14 Nov 2025 16:47:44 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 569D81E04C for ; Fri, 14 Nov 2025 16:47:44 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C17D73858422 for ; Fri, 14 Nov 2025 21:47:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C17D73858422 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=x2zifDl2 Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) by sourceware.org (Postfix) with ESMTPS id 49688385840D for ; Fri, 14 Nov 2025 21:43:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 49688385840D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 49688385840D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1763156583; cv=none; b=Tpvo9kJ5PQ+PbD62piGGcfDBqwcGjixJDA29sqHUf9VaNTTLdcE2Lkz3qnDqan2oNDOiEkJLJOWLngLj/T8pLJJxBtz3rRojz6Hn3Hn0GOB7a39uhHnTlNS4OeOiabJOmu3Xl28IqFzBNGS+wvy7z+S9GAiiOXMgcdNKWsIjBi4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1763156583; c=relaxed/simple; bh=cKBzwyP9jlJSE2XjewZt8GupdIZzTO2UaOQJcZS+0vE=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=VMUP17VFc3QMlmPsLhqzd8CYeZwEtiq5iGiLV22B273IiIZplGL530K4V3CWVR2Jq5mK0O4+lSiJZMKo6Fyqss+QWAU0Y6njIsPDqERCac8T1RfMeo+9F7gdQ/+n7cgxC9MVrcQ/SwHbHFmb8/MmEysC+5I4lik13eA6ab2/gA0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 49688385840D Received: from eig-obgw-6006b.ext.cloudfilter.net ([10.0.30.211]) by cmsmtp with ESMTPS id Jy5cviIYrKXDJK1ZOvCA5P; Fri, 14 Nov 2025 21:43:02 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id K1ZNvDX5uubbKK1ZOv7N8f; Fri, 14 Nov 2025 21:43:02 +0000 X-Authority-Analysis: v=2.4 cv=Ua5RSLSN c=1 sm=1 tr=0 ts=6917a266 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=6UeiqGixMTsA:10 a=ItBw4LHWJt0A:10 a=dzWzf_mpAAAA:8 a=D67Kr2i_5PULxVpJUKsA:9 a=b4DR9a7p2ZdsqdHBznES:22 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=HEwPT/0tVkdx3IEqSOQrG4ipykvzbn3UGj/R/lnpiP8=; b=x2zifDl2e265hWWyhe2w7PE8F+ lcFAAdMc9DRkHGnn0GJs3CNAhwnAc4q+Pc2HUjmN43oFiow8IcipTGvHaTvWj8mzo7596LPm/hr5e ZqxhUCPjvnO+wNfux5grtMGsO; Received: from 97-122-120-205.hlrn.qwest.net ([97.122.120.205]:38082 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vK1ZN-00000003toe-2qYI; Fri, 14 Nov 2025 14:43:01 -0700 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH v2] gdb: use gdb::unordered_{set,map} at a few places In-Reply-To: (Simon Marchi's message of "Fri, 14 Nov 2025 16:15:26 -0500") References: <20251113213506.313040-1-simon.marchi@efficios.com> <20251113214507.359286-1-simon.marchi@efficios.com> <87a50ov1gv.fsf@tromey.com> <87wm3stm63.fsf@tromey.com> <87o6p4tj55.fsf@tromey.com> X-Attribution: Tom Date: Fri, 14 Nov 2025 14:43:00 -0700 Message-ID: <87cy5kthnf.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.120.205 X-Source-L: No X-Exim-ID: 1vK1ZN-00000003toe-2qYI X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-120-205.hlrn.qwest.net (bapiya) [97.122.120.205]:38082 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfHeJf4ADZOvOaQpsUSy3GuBsAGdfY1JpJ+Wi/sh5zTRmeQgod/teKhr2AnkpR9qZPGQHek/pyz19yZ5xXOBKgsre2zqS8iUnO/02HglC4avHlbSMWQsC o0vujMgRHfQ+lTaNd2zvWGSeq/ETm2issepQSwTUR7eZ6S3wk0WG/Teda7fW3ZbaHzRHOvdLiTJ/wh/N5kBu2MJKxmchBrQD0i4= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: Simon> I think it's a bit odd to prevent copying this particular structure in Simon> the first place, since it's not that structure that controls the release Simon> of the resource, through its constructor. It's done externally. Yeah, I see now. You can leave it as is I guess. This type seems weird to me but on the other hand it's private to the class that actually manages it. Tom