Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Fellows <daniel.fellows@arm.com>
To: <simark@simark.ca>
Cc: <simon.marchi@efficios.com>, <gdb-patches@sourceware.org>,
	<tom@tromey.com>, <nd@arm.com>
Subject: Re: [PATCH v2] gdb: use gdb::unordered_{set,map} at a few places
Date: Mon, 27 Jul 2026 17:21:16 +0100	[thread overview]
Message-ID: <20260727162116.1042742-1-daniel.fellows@arm.com> (raw)
In-Reply-To: <58fa094b-25d1-4fd9-b5d6-14f3aff9b22b@simark.ca>

Hi Simon,

Would you be willing to backport the solib-svr4.c change from this patch
to gdb-17-branch?

We encountered the following build failure on both Intel and Arm macOS
hosts after moving to GDB 17:

gdb/solib-svr4.c:3769:3: error:
no template named 'unordered_map' in namespace 'std';
did you mean 'gdb::unordered_map'?

I tested changing this instance to gdb::unordered_map, and it fixes the
affected macOS builds.

The complete commit touches several unrelated files, has conflicts with
gdb-17-branch, and part of it was later reverted for x86-nat.c. Only the
solib-svr4.c change appears to be required here.

Would you be able to prepare that backport, or advise whether another
approach would be preferred?

Thanks,
Daniel

      reply	other threads:[~2026-07-27 16:23 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-13 21:35 [PATCH] " Simon Marchi
2025-11-13 21:43 ` [PATCH v2] " Simon Marchi
2025-11-14 19:49   ` Tom Tromey
2025-11-14 20:00     ` Simon Marchi
2025-11-14 20:05       ` Tom Tromey
2025-11-14 20:32         ` Simon Marchi
2025-11-14 21:10           ` Tom Tromey
2025-11-14 21:15             ` Simon Marchi
2025-11-14 21:43               ` Tom Tromey
2025-11-14 22:20                 ` Simon Marchi
2025-11-17 15:58                   ` Tom Tromey
2025-11-17 16:31                     ` Simon Marchi
2026-07-27 16:21                       ` Daniel Fellows [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260727162116.1042742-1-daniel.fellows@arm.com \
    --to=daniel.fellows@arm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=nd@arm.com \
    --cc=simark@simark.ca \
    --cc=simon.marchi@efficios.com \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox