From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Wa2lGPqaF2nEggIAWB0awg (envelope-from ) for ; Fri, 14 Nov 2025 16:11:22 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=Qcz3ETM3; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5D7451E04C; Fri, 14 Nov 2025 16:11:22 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DA4901E04C for ; Fri, 14 Nov 2025 16:11:21 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 69E283858D20 for ; Fri, 14 Nov 2025 21:11:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 69E283858D20 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=Qcz3ETM3 Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id D4D943858D1E for ; Fri, 14 Nov 2025 21:10:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D4D943858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D4D943858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1763154650; cv=none; b=DYwMuoQCL7AWjMnRNUPc0haPPif0FnJ5ZhCj9X5D8n6faRKjPF80JNhEkuTL4qwYEWFu7fxVe8/DeoGtoaezq9AAO3ZVcHgAEy8ol5RslajPoWZTOcJaxG8G6PzsOvh03QTuPk2BgMt7+k5Emkd21u8ripj7bRG3qGl7ivIfTr0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1763154650; c=relaxed/simple; bh=xsf+39Sirl7q2GiM3JYkmA0wbqWWZBOCBkzcMca6zeM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=lYZCSfbYn1FDrZpTm4ingtEWcev7fSUZoVT5vJzLONPsvfvUN+G+D0L4s04TUgWSuw8B2iHdOpxWVtRoT+7LXrgMAI87WeZ/9zgLrlVv5BihJPlQ1fGdj67aYHfWg8ycVkg89gPcekNJGLkmPhnE6R6RMPZNYc6d1AkiBptIQxE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D4D943858D1E Received: from eig-obgw-6006b.ext.cloudfilter.net ([10.0.30.211]) by cmsmtp with ESMTPS id JzASv0qXMZx2iK14Cv4qKP; Fri, 14 Nov 2025 21:10:48 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id K14CvCyMvubbKK14Cv6rX2; Fri, 14 Nov 2025 21:10:48 +0000 X-Authority-Analysis: v=2.4 cv=Ua5RSLSN c=1 sm=1 tr=0 ts=69179ad8 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=6UeiqGixMTsA:10 a=ItBw4LHWJt0A:10 a=7d_E57ReAAAA:8 a=OHAuYhHQ-bcUuCgueDgA:9 a=jhqOcbufqs7Y1TYCrUUU:22 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=KDbr2VVMJJFvvdUXo79/qSTEx8EbynZm7fRcpQJsGG8=; b=Qcz3ETM3HTtPG2gXD7P/Q453nL YpWr9h9K2cBZMmZwxTR5sux1k3WtrBRRKPrgyVit1aPbSQy3SZqOL+85C5gdLdr+pQqwFbVl+WlGH TXnKjkYoLRck7ezyNzxqdf9yX; Received: from 97-122-120-205.hlrn.qwest.net ([97.122.120.205]:37868 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vK14C-00000000cE4-0B2i; Fri, 14 Nov 2025 14:10:48 -0700 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH v2] gdb: use gdb::unordered_{set,map} at a few places In-Reply-To: (Simon Marchi's message of "Fri, 14 Nov 2025 15:32:13 -0500") References: <20251113213506.313040-1-simon.marchi@efficios.com> <20251113214507.359286-1-simon.marchi@efficios.com> <87a50ov1gv.fsf@tromey.com> <87wm3stm63.fsf@tromey.com> X-Attribution: Tom Date: Fri, 14 Nov 2025 14:10:46 -0700 Message-ID: <87o6p4tj55.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.120.205 X-Source-L: No X-Exim-ID: 1vK14C-00000000cE4-0B2i X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-120-205.hlrn.qwest.net (bapiya) [97.122.120.205]:37868 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfJpbMjl/UwaT/0zMhezpUhXTC/SL4r9y9KESvlRQYoem/K3642LaNiWIa78hW/rFpruKDW2zJ2e03DNhK2i7TBUudJcXBujP3oqmkD/cD8IWzkWSryFz 4tBS5FCscemVpuF67IEjllAiM5MIg80vtQzmSjmKLMib37mX43cbb1SstOJCQmBDqoGqFnMJX+0BYagrfbmyDxkYMv2xLUEwYNk= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: >> The move operators are fine, this particular part of the note is just >> saying that perhaps proc_mem_file would benefit from the explicit >> addition of DISABLE_COPY_AND_ASSIGN. However it's not truly needed. Simon> Ok, I have no problem being more explicit than necessary and using Simon> DISABLE_COPY_AND_ASSIGN there. See updated patch below. Simon> struct refcnt_fd Simon> { Simon> - DISABLE_COPY_AND_ASSIGN (refcnt_fd); Simon> refcnt_fd (int fd, int refcnt) : fd (fd), refcnt (refcnt) {} I still think this removal is in error. Is it really needed? Allowing copying here would surely lead to bugs. Tom