From: Simon Marchi <simon.marchi@efficios.com>
To: Andrew Burgess <aburgess@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v6 3/3] gdb/dwarf: add cooked_index_entry::parent_is_deferred
Date: Thu, 24 Sep 2026 22:34:24 -0400 [thread overview]
Message-ID: <883579be-3b65-40b8-9d73-8fbaeb683991@efficios.com> (raw)
In-Reply-To: <87v77u1id8.fsf@redhat.com>
On 9/24/26 4:53 PM, Andrew Burgess wrote:
>
> This looks good to me. But because I have to find something to earn my
> pay...
>
> Simon Marchi <simon.marchi@efficios.com> writes:
>
>> Add a parent_is_deferred method to cooked_index_entry, mirroring
>> name_is_deferred, and use it instead of checkingthe IS_PARENT_DEFERRED
>
> ... missing space in 'checkingthe'.
Fixed.
> But otherwise, LGTM:
>
> Approved-By: Andrew Burgess <aburgess@redhat.com>
Thanks, will push to master and gdb-18-branch.
Simon
next prev parent reply other threads:[~2026-09-25 2:34 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-19 10:03 [PATCH] [GDB 18] gdb: resolve class name via DW_AT_signature in cooked index Andrew Burgess
2026-08-21 17:07 ` Tom Tromey
2026-08-28 21:30 ` [PATCHv2] " Andrew Burgess
2026-09-01 13:31 ` [PATCHv3] " Andrew Burgess
2026-09-10 16:11 ` Simon Marchi
2026-09-11 19:18 ` Tom Tromey
2026-09-12 2:06 ` Simon Marchi
2026-09-14 13:23 ` Andrew Burgess
2026-09-14 14:57 ` Simon Marchi
2026-09-14 15:38 ` Tom Tromey
2026-09-15 10:25 ` Andrew Burgess
2026-09-15 15:01 ` Tom Tromey
2026-09-15 15:55 ` Simon Marchi
2026-09-15 17:21 ` Simon Marchi
2026-09-16 11:40 ` Andrew Burgess
2026-09-16 11:45 ` Andrew Burgess
2026-09-16 11:48 ` Andrew Burgess
2026-09-14 15:36 ` Tom Tromey
2026-09-10 16:18 ` Simon Marchi
2026-09-16 11:38 ` [PATCHv4] " Andrew Burgess
2026-09-22 4:26 ` Simon Marchi
2026-09-23 13:47 ` Simon Marchi
2026-09-24 4:59 ` [PATCH 0/2] " Simon Marchi
2026-09-24 5:05 ` Simon Marchi
2026-09-24 15:09 ` [PATCH v6 0/3] gdb/dwarf: " Simon Marchi
2026-09-24 15:09 ` [PATCH v6 1/3] gdb/dwarf: split cooked index finalization into separate steps Simon Marchi
2026-09-24 15:09 ` [PATCH v6 2/3] gdb/dwarf: resolve class name via DW_AT_signature in cooked index Simon Marchi
2026-09-24 15:09 ` [PATCH v6 3/3] gdb/dwarf: add cooked_index_entry::parent_is_deferred Simon Marchi
2026-09-24 20:53 ` Andrew Burgess
2026-09-25 2:34 ` Simon Marchi [this message]
2026-09-24 4:59 ` [PATCH 1/2] gdb: split cooked index finalization into separate steps Simon Marchi
2026-09-24 10:16 ` Andrew Burgess
2026-09-24 14:24 ` Simon Marchi
2026-09-24 4:59 ` [PATCH 2/2] gdb: resolve class name via DW_AT_signature in cooked index Simon Marchi
2026-09-24 10:39 ` Andrew Burgess
2026-09-24 15:07 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=883579be-3b65-40b8-9d73-8fbaeb683991@efficios.com \
--to=simon.marchi@efficios.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox